Opened 5 years ago

Closed 5 years ago

#14865 closed (fixed)

Various RO localflavor fields don't handle EMPTY_VALUES correctly

Reported by: idangazit Owned by: idangazit
Component: contrib.localflavor Version: 1.2
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


Fields with required=False should not choke while cleaning any value in EMPTY_VALUES (from django.core.validators):

EMPTY_VALUES = (None, , [], (), {})

Attachments (1)

14865.diff (1.2 KB) - added by idangazit 5 years ago.

Download all attachments as: .zip

Change History (4)

Changed 5 years ago by idangazit

comment:1 Changed 5 years ago by idangazit

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Status changed from new to assigned

comment:2 Changed 5 years ago by idangazit

  • Triage Stage changed from Unreviewed to Accepted

comment:3 Changed 5 years ago by idangazit

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [14951]) Fixed #14864, #14865 -- ROCIFField didn't accept values starting with RO, as it was supposed to, and ROCNPField, ROIBANField, and ROPhoneNumberField didn't handle all EMPTY_VALUES correctly. Also converted Romanian localflavor doctests to unittests. We have always been at war with doctests. Thanks to Idan Gazit.

Fixing RO localflavor clean() #14865

Note: See TracTickets for help on using tickets.
Back to Top