Opened 13 years ago
Closed 13 years ago
#14864 closed (fixed)
ROCIFField in localflavor has a bad regex
| Reported by: | Idan Gazit | Owned by: | Idan Gazit |
|---|---|---|---|
| Component: | contrib.localflavor | Version: | 1.2 |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Valid values are 2-10 digit numbers, optionally prefixed by the uppercase characters 'RO'.
On L33, there is logic for removing the prefix if it exists, but the regex in __init__ does not account for the prefix, leading to ValidationErrors when super.clean() is called.
Attachments (1)
Change History (4)
by , 13 years ago
| Attachment: | 14864.diff added |
|---|
comment:1 by , 13 years ago
| Status: | new → assigned |
|---|
comment:2 by , 13 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:3 by , 13 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
(In [14951]) Fixed #14864, #14864 -- ROCIFField didn't accept values starting with RO, as it was supposed to, and ROCNPField, ROIBANField, and ROPhoneNumberField didn't handle all EMPTY_VALUES correctly. Also converted Romanian localflavor doctests to unittests. We have always been at war with doctests. Thanks to Idan Gazit.
Fixing RO localflavor clean() #14864