Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#14860 closed (fixed)

Various PL localflavor fields don't handle EMPTY_VALUES correctly

Reported by: Idan Gazit Owned by: Idan Gazit
Component: contrib.localflavor Version: 1.2
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Fields with required=False should not choke while cleaning any value in EMPTY_VALUES (from django.core.validators):

EMPTY_VALUES = (None, , [], (), {})

Attachments (1)

14860.diff​ (1.5 KB ) - added by Idan Gazit 13 years ago.

Download all attachments as: .zip

Change History (5)

by Idan Gazit, 13 years ago

Attachment: 14860.diff​ added

comment:1 by Idan Gazit, 13 years ago

Status: new → assigned

comment:2 by Idan Gazit, 13 years ago

Triage Stage: Unreviewed → Accepted

comment:3 by Alex Gaynor, 13 years ago

Resolution: → fixed
Status: assigned → closed

(In [14949]) Fixed #14860 -- PLPESELField, PLNIPField, and PLREGONField didn't handle all EMPTY_VALUES correctly. Also converted teh Polish localflavor doctests into unittests. We have always been at war with doctests. Thanks to Idan Gazit.

comment:4 by Alex Gaynor, 13 years ago

(In [14973]) [1.2.X] Fixed #14860 -- PLPESELField, PLNIPField, and PLREGONField didn't handle all EMPTY_VALUES correctly. Also converted teh Polish localflavor doctests into unittests. We have always been at war with doctests. Thanks to Idan Gazit. Backport of [14949].

Note: See TracTickets for help on using tickets.
Back to Top