#14859 closed (fixed)
Various IT localflavor fields don't handle EMPTY_VALUES correctly
Reported by: | Idan Gazit | Owned by: | Idan Gazit |
---|---|---|---|
Component: | contrib.localflavor | Version: | 1.2 |
Severity: | Keywords: | ||
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Fields with required=False should not choke while cleaning any value in EMPTY_VALUES (from django.core.validators):
EMPTY_VALUES = (None, , [], (), {})
Attachments (1)
Change History (5)
by , 14 years ago
Attachment: | 14859.diff added |
---|
comment:1 by , 14 years ago
Status: | new → assigned |
---|
comment:2 by , 14 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:3 by , 14 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:4 by , 14 years ago
Note:
See TracTickets
for help on using tickets.
(In [14945]) Fixed #14859 -- ITSocialSecurityNumberField and ITVatNumberField didn't handle all EMPTY_VALUES gracefully. Also converted the Italias localflavor doctests into unittests. We have always been at war with doctests. Thanks to Idan Gazit.