Opened 13 years ago
Closed 13 years ago
#14699 closed Cleanup/optimization (fixed)
FormWizard tests are scattered between two test modules
| Reported by: | Luke Plant | Owned by: | nobody |
|---|---|---|---|
| Component: | Testing framework | Version: | 1.2 |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Tests for these classes are found in regressiontests/formwizard and in django/contrib/formtools/tests with significant overlap, which appears to be an accident - from [10316] it seems that Jacob didn't realise that there were already some FormWizard tests added in [8603].
All the tests should be moved to django/contrib/formtools to make it easy to find them.
The only difficult thing is deciding how to merge them - they overlap significantly. It is probably best to:
- copy some of the details of the regressiontests/forms.py to the contrib tests (the
NullBooleanFieldis required to check #9473) - bulk out the contrib tests to do a complete walk-though like the regressiontests.
Change History (3)
comment:1 by , 13 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:2 by , 13 years ago
| Severity: | → Normal |
|---|---|
| Type: | → Cleanup/optimization |
comment:3 by , 13 years ago
| Easy pickings: | unset |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Fixed in [16307].
Note:
See TracTickets
for help on using tickets.
Confirmed and accepting the ticket.