Code

Opened 4 years ago

Closed 3 years ago

#14699 closed Cleanup/optimization (fixed)

FormWizard tests are scattered between two test modules

Reported by: lukeplant Owned by: nobody
Component: Testing framework Version: 1.2
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX:

Description

Tests for these classes are found in regressiontests/formwizard and in django/contrib/formtools/tests with significant overlap, which appears to be an accident - from [10316] it seems that Jacob didn't realise that there were already some FormWizard tests added in [8603].

All the tests should be moved to django/contrib/formtools to make it easy to find them.

The only difficult thing is deciding how to merge them - they overlap significantly. It is probably best to:

  • copy some of the details of the regressiontests/forms.py to the contrib tests (the NullBooleanField is required to check #9473)
  • bulk out the contrib tests to do a complete walk-though like the regressiontests.

Attachments (0)

Change History (3)

comment:1 Changed 4 years ago by rasca

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Confirmed and accepting the ticket.

comment:2 Changed 3 years ago by jaddison

  • Severity set to Normal
  • Type set to Cleanup/optimization

comment:3 Changed 3 years ago by ramiro

  • Easy pickings unset
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [16307].

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.