Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#14589 closed (fixed)

Changeset 14395 introduced two bugs

Reported by: Adam Mckerlie <adammckerlie@…> Owned by: nobody
Component: Template system Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Traceback (most recent call last):

File "/Users/adamm/Sites/virtualenvs/django-maintenance-mode/lib/python2.6/site-packages/django/core/servers/basehttp.py", line 281, in run

self.result = application(self.environ, self.start_response)

File "/Users/adamm/Sites/virtualenvs/django-maintenance-mode/lib/python2.6/site-packages/django/contrib/staticfiles/handlers.py", line 57, in call

return self.application(environ, start_response)

File "/Users/adamm/Sites/virtualenvs/django-maintenance-mode/lib/python2.6/site-packages/django/contrib/staticfiles/handlers.py", line 57, in call

return self.application(environ, start_response)

File "/Users/adamm/Sites/virtualenvs/django-maintenance-mode/lib/python2.6/site-packages/django/core/handlers/wsgi.py", line 262, in call

response = self.get_response(request)

File "/Users/adamm/Sites/virtualenvs/django-maintenance-mode/lib/python2.6/site-packages/django/core/handlers/base.py", line 137, in get_response

return debug.technical_404_response(request, e)

File "/Users/adamm/Sites/virtualenvs/django-maintenance-mode/lib/python2.6/site-packages/django/views/debug.py", line 276, in technical_404_response

return empty_urlconf(request)

File "/Users/adamm/Sites/virtualenvs/django-maintenance-mode/lib/python2.6/site-packages/django/views/debug.py", line 295, in empty_urlconf

return HttpResponse(t.render(c), mimetype='text/html')

File "/Users/adamm/Sites/virtualenvs/django-maintenance-mode/lib/python2.6/site-packages/django/template/init.py", line 173, in render

return self._render(context)

File "/Users/adamm/Sites/virtualenvs/django-maintenance-mode/lib/python2.6/site-packages/django/template/init.py", line 167, in _render

return self.nodelist.render(context)

File "/Users/adamm/Sites/virtualenvs/django-maintenance-mode/lib/python2.6/site-packages/django/template/init.py", line 796, in render

bits.append(self.render_node(node, context))

File "/Users/adamm/Sites/virtualenvs/django-maintenance-mode/lib/python2.6/site-packages/django/template/debug.py", line 73, in render_node

result = node.render(context)

File "/Users/adamm/Sites/virtualenvs/django-maintenance-mode/lib/python2.6/site-packages/django/template/debug.py", line 91, in render

output = localize(value, use_l10n=use_l10n)

TemplateSyntaxError: Caught NameError while rendering: global name 'value' is not defined

Attachments (1)

fix_changeset_14395.patch (517 bytes) - added by Adam Mckerlie <adammckerlie@…> 4 years ago.
Patch that fixes the issues.

Download all attachments as: .zip

Change History (5)

Changed 4 years ago by Adam Mckerlie <adammckerlie@…>

Patch that fixes the issues.

comment:1 Changed 4 years ago by Adam Mckerlie <adammckerlie@…>

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Note that this happens on a fresh install of trunk.

comment:2 Changed 4 years ago by kmike

I can confirm that tests are failing.

comment:3 Changed 4 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [14397]) Fixed #14589 -- Corrected a copy-and-paste error introduced in r14395. Thanks to Adam McKerlie for the report.

comment:4 Changed 4 years ago by jacob

  • milestone 1.3 deleted

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top