#14572 closed Bug (fixed)
Minor fix for generic inline formsets
Reported by: | Simon Litchfield | Owned by: | nobody |
---|---|---|---|
Component: | contrib.contenttypes | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Following on from #13095, generic_inlineformset_factory also needs a minor patch.
<lambda>() got an unexpected keyword argument 'widget'
Attachments (3)
Change History (13)
by , 14 years ago
Attachment: | generic-fix.diff added |
---|
comment:1 by , 14 years ago
milestone: | → 1.3 |
---|---|
Version: | 1.2 → SVN |
comment:2 by , 14 years ago
Needs tests: | set |
---|---|
Triage Stage: | Unreviewed → Accepted |
Could you provide a test that demonstrates this behavior? Thanks!
comment:3 by , 14 years ago
Needs tests: | unset |
---|
I tested the patch against the current trunk and added tests.
comment:4 by , 14 years ago
Component: | Contrib apps → contrib.contenttypes |
---|
comment:5 by , 13 years ago
Severity: | → Normal |
---|---|
Type: | → Bug |
comment:6 by , 13 years ago
Easy pickings: | unset |
---|---|
Patch needs improvement: | set |
I can imagine how it could be useful to pass **kwargs
to GenericInlineModelAdmin.get_formset()
but this would be a new feature that is not relevant to the original bug report in this ticket. The patch should focus on the bug and a new ticket could be opened specifically for that new feature.
comment:7 by , 13 years ago
Patch needs improvement: | unset |
---|
Thanks for reviewing this. I removed the portion that added kwargs from the patch. That feature is documented in #9588.
comment:8 by , 13 years ago
Triage Stage: | Accepted → Ready for checkin |
---|
Thanks for updating the patch. That looks great.
Note this also adds kwargs support to GenericInlineModelAdmin, as per InlineModelAdmin.