Opened 13 years ago

Closed 11 years ago

Last modified 11 years ago

#14571 closed Cleanup/optimization (fixed)

Update jQuery

Reported by: Rob Hudson Owned by: Alexander Herrmann
Component: contrib.admin Version: 1.2
Severity: Normal Keywords: jquery sprintnov13
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: yes

Description (last modified by Jannis Leidel)

A new jQuery has been released with some nice performance improvements:
http://blog.jquery.com/2010/11/11/jquery-1-4-4-release-notes/

Change History (22)

comment:1 by Rob Hudson, 13 years ago

Has patch: set

Trac wouldn't accept my patch because of the file size (278k?). You can find a diff on my github repo:
http://github.com/robhudson/django/tree/jquery-1.4.3

comment:2 by anonymous, 13 years ago

Maybe better use CDN hosted copy of jquery instead of including it in distribution?

http://docs.jquery.com/Downloading_jQuery#CDN_Hosted_jQuery

comment:3 by Jannis Leidel, 13 years ago

milestone: 1.3
Triage Stage: UnreviewedAccepted

Using a hosted version seems not like a good idea given potential uses of Django in intranets etc. Updating jQuery seems reasonable though.

comment:4 by Rob Hudson, 13 years ago

Agreed that a hosted version would be bad for offline scenarios.

Attaching a patch for 1.4.4 which just came out...

comment:5 by Rob Hudson, 13 years ago

Oh right... diff is too big. See github: https://github.com/robhudson/django/tree/jquery-1.4.4

comment:6 by Jannis Leidel, 13 years ago

Description: modified (diff)
Summary: Update jQuery to v1.4.3Update jQuery to v1.4.4

comment:7 by steph, 13 years ago

Keywords: sprintnov13 added

comment:8 by ootync, 13 years ago

Careful, there is one "Backwards-incompatible changes in jQuery 1.4.4": http://blog.jquery.com/2010/11/11/jquery-1-4-4-release-notes/

width() & height() no longer return 0 for hidden elements.

comment:9 by Jannis Leidel, 13 years ago

http://ejohn.org/blog/learning-from-twitter/ describes another funny side effect that we should test thoroughly before upgrading

comment:10 by Julien Phalip, 13 years ago

milestone: 1.31.4
Summary: Update jQuery to v1.4.4Update jQuery

jQuery 1.5 was released yesterday :)
http://blog.jquery.com/2011/01/31/jquery-15-released/

This is not critical for 1.3 but certainly worthwhile for 1.4.

comment:11 by Jannis Leidel, 13 years ago

Easy pickings: unset
Patch needs improvement: set
Severity: Normal
Type: Cleanup/optimization

comment:12 by Julien Phalip, 13 years ago

UI/UX: set

comment:13 by Alexander Herrmann, 13 years ago

Owner: changed from nobody to Alexander Herrmann
Status: newassigned

comment:14 by Alexander Herrmann, 13 years ago

Patch needs improvement: unset

as the attachment file size limit applies for the patch, find it here: http://dl.dropbox.com/u/9067878/Django/14571-r16351.diff
it has jQuery 1.6.1 now included and the deprecated/changes functions adjusted

Last edited 13 years ago by Alexander Herrmann (previous) (diff)

comment:15 by Jannis Leidel, 13 years ago

Triage Stage: AcceptedReady for checkin

comment:16 by Julien Phalip, 13 years ago

milestone: 1.4
Triage Stage: Ready for checkinAccepted

I've just talked to jezdez on IRC and we agree that it is too risky to upgrade jQuery at this stage, now that we're approaching the end of the 1.4 release cycle. Where it may bring negligible performance improvements, it may also break existing code. In the absence of a proper JS testing framework we're not willing to take that risk for the moment. The situation can be reassessed after 1.4 ships.

comment:17 by Claude Paroz, 12 years ago

Patch needs improvement: set

Now would be a good time to update jQuery. What about the version? Either the latest 1.6 (1.6.4) or the latest 1.7.2.

comment:18 by Claude Paroz, 11 years ago

Unless someone opposes, I will update the patch to current 1.9.1 version of jQuery and commit it (as long as all current Selenium tests pass). The forthcoming sprint might also be a good opportunity to test/fix JS issues.

comment:19 by Claude Paroz <claude@…>, 11 years ago

Resolution: fixed
Status: assignedclosed

In 8bbca211b6d4457e2f7acc3d41e54373f03ecddd:

Fixed #14571 -- Updated embedded jQuery from 1.4.2 to 1.9.1

Thanks dArignac for the initial patch.

comment:20 by Tim Graham, 11 years ago

I think this should be mentioned in the release notes as well as https://docs.djangoproject.com/en/dev/ref/contrib/admin/#jquery

comment:21 by Claude Paroz, 11 years ago

Agreed for updating the linked docs. I grepped the release notes, and found no mention of jQuery at all, that's why I didn't touch them. But if you think it's worth noting, I can do it.

comment:22 by Claude Paroz <claude@…>, 11 years ago

In 60fff6fc9496c7c851182dd6ebac10bb011be2ba:

Documented jQuery upgrade

Refs #14571.

Note: See TracTickets for help on using tickets.
Back to Top