#14571 closed Cleanup/optimization (fixed)
Update jQuery
| Reported by: | robhudson | Owned by: | dArignac |
|---|---|---|---|
| Component: | contrib.admin | Version: | 1.2 |
| Severity: | Normal | Keywords: | jquery sprintnov13 |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | yes |
Description (last modified by jezdez)
A new jQuery has been released with some nice performance improvements:
http://blog.jquery.com/2010/11/11/jquery-1-4-4-release-notes/
Attachments (0)
Change History (22)
comment:1 Changed 4 years ago by robhudson
- Has patch set
- Needs documentation unset
- Needs tests unset
- Patch needs improvement unset
comment:2 Changed 4 years ago by anonymous
Maybe better use CDN hosted copy of jquery instead of including it in distribution?
http://docs.jquery.com/Downloading_jQuery#CDN_Hosted_jQuery
comment:3 Changed 4 years ago by jezdez
- milestone set to 1.3
- Triage Stage changed from Unreviewed to Accepted
Using a hosted version seems not like a good idea given potential uses of Django in intranets etc. Updating jQuery seems reasonable though.
comment:4 Changed 4 years ago by robhudson
Agreed that a hosted version would be bad for offline scenarios.
Attaching a patch for 1.4.4 which just came out...
comment:5 Changed 4 years ago by robhudson
Oh right... diff is too big. See github: https://github.com/robhudson/django/tree/jquery-1.4.4
comment:6 Changed 4 years ago by jezdez
- Description modified (diff)
- Summary changed from Update jQuery to v1.4.3 to Update jQuery to v1.4.4
comment:7 Changed 4 years ago by steph
- Keywords sprintnov13 added
comment:8 Changed 3 years ago by ootync
Careful, there is one "Backwards-incompatible changes in jQuery 1.4.4": http://blog.jquery.com/2010/11/11/jquery-1-4-4-release-notes/
width() & height() no longer return 0 for hidden elements.
comment:9 Changed 3 years ago by jezdez
http://ejohn.org/blog/learning-from-twitter/ describes another funny side effect that we should test thoroughly before upgrading
comment:10 Changed 3 years ago by julien
- milestone changed from 1.3 to 1.4
- Summary changed from Update jQuery to v1.4.4 to Update jQuery
jQuery 1.5 was released yesterday :)
http://blog.jquery.com/2011/01/31/jquery-15-released/
This is not critical for 1.3 but certainly worthwhile for 1.4.
comment:11 Changed 3 years ago by jezdez
- Easy pickings unset
- Patch needs improvement set
- Severity set to Normal
- Type set to Cleanup/optimization
jQuery 1.6 was released: http://blog.jquery.com/2011/05/03/jquery-16-released/
comment:12 Changed 3 years ago by julien
- UI/UX set
comment:13 Changed 3 years ago by dArignac
- Owner changed from nobody to dArignac
- Status changed from new to assigned
comment:14 Changed 3 years ago by dArignac
- Patch needs improvement unset
as the attachment file size limit applies for the patch, find it here: http://dl.dropbox.com/u/9067878/Django/14571-r16351.diff
it has jQuery 1.6.1 now included and the deprecated/changes functions adjusted
comment:15 Changed 3 years ago by jezdez
- Triage Stage changed from Accepted to Ready for checkin
comment:16 Changed 3 years ago by julien
- milestone 1.4 deleted
- Triage Stage changed from Ready for checkin to Accepted
I've just talked to jezdez on IRC and we agree that it is too risky to upgrade jQuery at this stage, now that we're approaching the end of the 1.4 release cycle. Where it may bring negligible performance improvements, it may also break existing code. In the absence of a proper JS testing framework we're not willing to take that risk for the moment. The situation can be reassessed after 1.4 ships.
comment:17 Changed 2 years ago by claudep
- Patch needs improvement set
Now would be a good time to update jQuery. What about the version? Either the latest 1.6 (1.6.4) or the latest 1.7.2.
comment:18 Changed 17 months ago by claudep
Unless someone opposes, I will update the patch to current 1.9.1 version of jQuery and commit it (as long as all current Selenium tests pass). The forthcoming sprint might also be a good opportunity to test/fix JS issues.
comment:19 Changed 17 months ago by Claude Paroz <claude@…>
- Resolution set to fixed
- Status changed from assigned to closed
comment:20 Changed 17 months ago by timo
I think this should be mentioned in the release notes as well as https://docs.djangoproject.com/en/dev/ref/contrib/admin/#jquery
comment:21 Changed 17 months ago by claudep
Agreed for updating the linked docs. I grepped the release notes, and found no mention of jQuery at all, that's why I didn't touch them. But if you think it's worth noting, I can do it.
Trac wouldn't accept my patch because of the file size (278k?). You can find a diff on my github repo:
http://github.com/robhudson/django/tree/jquery-1.4.3