Code

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#14454 closed (fixed)

Convert admin_widgets doctest to unit tests

Reported by: prestontimmons Owned by: nobody
Component: Testing framework Version: master
Severity: Keywords: admin test
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: UI/UX:

Description

Attached is a patch that converts the admin_widgets doctests to unit tests. These changes were tested against trunk 14196 using the sqlite test settings.

Attachments (2)

admin_widgets.diff (16.9 KB) - added by prestontimmons 4 years ago.
admin_widgets_corrected.diff (16.8 KB) - added by prestontimmons 4 years ago.

Download all attachments as: .zip

Change History (7)

Changed 4 years ago by prestontimmons

comment:1 Changed 4 years ago by Alex

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement set
  • Triage Stage changed from Unreviewed to Accepted

The patch doesn't apply cleanly for me at HEAD. Looks like it hasn't been properly updated since unittest2 landed. If you could update it I'll look at merging it pronto.

Changed 4 years ago by prestontimmons

comment:2 Changed 4 years ago by prestontimmons

Thanks, Alex. I updated the patch against 14217. One of the lines in the first patch had trailing whitespace which git didn't approve of. It should apply cleanly now.

comment:3 Changed 4 years ago by Alex

  • Resolution set to fixed
  • Status changed from new to closed

(In [14221]) Fixed #14454 -- converted admin_widgets tests from doctests to unittests. We have always been at war with doctests. Thanks to prestontimmons for the patch.

comment:4 Changed 4 years ago by Alex

(In [14222]) [1.2.x] Fixed #14454 -- converted admin_widgets tests from doctests to unittests. We have always been at war with doctests. Thanks to prestontimmons for the patch. Backport of [14221].

comment:5 Changed 3 years ago by jacob

  • milestone 1.3 deleted

Milestone 1.3 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.