Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#14454 closed (fixed)

Convert admin_widgets doctest to unit tests

Reported by: Preston Timmons Owned by: nobody
Component: Testing framework Version: master
Severity: Keywords: admin test
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: UI/UX:

Description

Attached is a patch that converts the admin_widgets doctests to unit tests. These changes were tested against trunk 14196 using the sqlite test settings.

Attachments (2)

admin_widgets.diff (16.9 KB) - added by Preston Timmons 6 years ago.
admin_widgets_corrected.diff (16.8 KB) - added by Preston Timmons 6 years ago.

Download all attachments as: .zip

Change History (7)

Changed 6 years ago by Preston Timmons

Attachment: admin_widgets.diff added

comment:1 Changed 6 years ago by Alex Gaynor

Patch needs improvement: set
Triage Stage: UnreviewedAccepted

The patch doesn't apply cleanly for me at HEAD. Looks like it hasn't been properly updated since unittest2 landed. If you could update it I'll look at merging it pronto.

Changed 6 years ago by Preston Timmons

comment:2 Changed 6 years ago by Preston Timmons

Thanks, Alex. I updated the patch against 14217. One of the lines in the first patch had trailing whitespace which git didn't approve of. It should apply cleanly now.

comment:3 Changed 6 years ago by Alex Gaynor

Resolution: fixed
Status: newclosed

(In [14221]) Fixed #14454 -- converted admin_widgets tests from doctests to unittests. We have always been at war with doctests. Thanks to prestontimmons for the patch.

comment:4 Changed 6 years ago by Alex Gaynor

(In [14222]) [1.2.x] Fixed #14454 -- converted admin_widgets tests from doctests to unittests. We have always been at war with doctests. Thanks to prestontimmons for the patch. Backport of [14221].

comment:5 Changed 5 years ago by Jacob

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top