Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#14447 closed (fixed)

Auth and Sitemap test failures from test

Reported by: Gabriel Hurley Owned by: Gabriel Hurley
Component: Contrib apps Version: 1.2
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


The contrib.auth and contrib.sitemap tests pass perfectly when run from Django's test suite, but they can potentially raise multiple failures depending on a project's settings.


  1. contrib.auth's testLoginRequired fails when LOGIN_URL is set to something other than "/login/". (post [13723])
  2. contrib.sitemaps had several dependencies on contrib.flatpages (post [13734])
  3. contrib.sitemaps's test_generic_sitemap fails when a fixture loads in extra User objects. (post [13676])

The attached patches fix all of the above, and still pass the full test suite. One patch for trunk, one patch for 1.2.X.

Please note that issue 3 actually exists in the current 1.2.3 release. The rest have been introduced since then.

Attachments (2)

fixes_trunk.diff (3.1 KB) - added by Gabriel Hurley 6 years ago.
fixes_1.2.X.diff (3.9 KB) - added by Gabriel Hurley 6 years ago.

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by Gabriel Hurley

Attachment: fixes_trunk.diff added

Changed 6 years ago by Gabriel Hurley

Attachment: fixes_1.2.X.diff added

comment:1 Changed 6 years ago by Gabriel Hurley

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Status: newassigned
Triage Stage: UnreviewedAccepted

comment:2 Changed 6 years ago by Russell Keith-Magee

Resolution: fixed
Status: assignedclosed

(In [14184]) Fixed #14447 -- Modified the auth and sitemaps tests to remove some assumptions about the environment in which the tests are run. Thanks to Gabriel Hurley for the report and patch.

comment:3 Changed 5 years ago by Jacob

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top