Code

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#14447 closed (fixed)

Auth and Sitemap test failures from manage.py test

Reported by: gabrielhurley Owned by: gabrielhurley
Component: Contrib apps Version: 1.2
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The contrib.auth and contrib.sitemap tests pass perfectly when run from Django's test suite, but they can potentially raise multiple failures depending on a project's settings.

Issues:

  1. contrib.auth's testLoginRequired fails when LOGIN_URL is set to something other than "/login/". (post [13723])
  2. contrib.sitemaps had several dependencies on contrib.flatpages (post [13734])
  3. contrib.sitemaps's test_generic_sitemap fails when a fixture loads in extra User objects. (post [13676])

The attached patches fix all of the above, and still pass the full test suite. One patch for trunk, one patch for 1.2.X.

Please note that issue 3 actually exists in the current 1.2.3 release. The rest have been introduced since then.

Attachments (2)

fixes_trunk.diff (3.1 KB) - added by gabrielhurley 4 years ago.
fixes_1.2.X.diff (3.9 KB) - added by gabrielhurley 4 years ago.

Download all attachments as: .zip

Change History (5)

Changed 4 years ago by gabrielhurley

Changed 4 years ago by gabrielhurley

comment:1 Changed 4 years ago by gabrielhurley

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Status changed from new to assigned
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 4 years ago by russellm

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [14184]) Fixed #14447 -- Modified the auth and sitemaps tests to remove some assumptions about the environment in which the tests are run. Thanks to Gabriel Hurley for the report and patch.

comment:3 Changed 3 years ago by jacob

  • milestone 1.3 deleted

Milestone 1.3 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.