Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#14349 closed (fixed)

Add Belgium (be) localflavor

Reported by: laurentluce Owned by: laurentluce
Component: contrib.localflavor Version: master
Severity: Keywords: localflavor belgium
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Should include post code, phone numbers and provinces.

Attachments (5)

be_localflavor.diff (15.1 KB) - added by laurentluce 5 years ago.
be_localflavor.2.diff (15.3 KB) - added by laurentluce 5 years ago.
add support for 0xxxxxxxx, 04xxxxxxxx phone number format. Wrap long lines.
be_localflavor.3.diff (12.9 KB) - added by laurentluce 5 years ago.
3rd version - add unittests instead of doctests
be_localflavor.4.diff (12.9 KB) - added by laurentluce 5 years ago.
minor fix - doc underline too short
be_localflavor.5.diff (13.8 KB) - added by laurentluce 5 years ago.
update docs and unit tests for phone number with dots in format as seen in use in Belgium

Download all attachments as: .zip

Change History (14)

comment:1 Changed 5 years ago by laurentluce

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Status changed from new to assigned

comment:2 Changed 5 years ago by laurentluce

  • Triage Stage changed from Unreviewed to Accepted

Changed 5 years ago by laurentluce

comment:3 Changed 5 years ago by laurentluce

  • Has patch set

patch contains the following:

  • forms.py with BEPostalCodeField, BEPhoneNumberField, BERegionSelect, BEProvinceSelect
  • be_regions.py with the 3 Belgium regions
  • be_provinces.py with the 11 Belgium provinces
  • added tests be.py and updated tests/regressiontests/forms/tests.py

Changed 5 years ago by laurentluce

add support for 0xxxxxxxx, 04xxxxxxxx phone number format. Wrap long lines.

comment:4 Changed 5 years ago by gvangool

One more thing, you might want to switch from doctests to unittests.
It has come up on the mailing list once before in a message from Alex.

comment:5 Changed 5 years ago by russellm

  • Patch needs improvement set

We're in the process of trying to purge the doctests from our test suite. We're trying to avoid adding doctests if at all possible, and doctests for completely new functionality are one of those things that are easy to avoid.

Changed 5 years ago by laurentluce

3rd version - add unittests instead of doctests

comment:6 Changed 5 years ago by laurentluce

  • Patch needs improvement unset
  • Replaced doctests by unittests.
  • Modified tests/regressiontests/forms/tests.py to import BE localflavor unit tests properly
  • Add my name to AUTHORS

comment:7 Changed 5 years ago by russellm

  • Triage Stage changed from Accepted to Ready for checkin

Patch looks good; marking RFC.

Changed 5 years ago by laurentluce

minor fix - doc underline too short

Changed 5 years ago by laurentluce

update docs and unit tests for phone number with dots in format as seen in use in Belgium

comment:8 Changed 5 years ago by jezdez

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [14160]) Fixed #14349 -- Added Belgium localflavor. Thanks for the report and patch, Laurent Luce.

comment:9 Changed 4 years ago by jacob

  • milestone 1.3 deleted

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top