Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#14349 closed (fixed)

Add Belgium (be) localflavor

Reported by: laurentluce Owned by: laurentluce
Component: contrib.localflavor Version: dev
Severity: Keywords: localflavor belgium
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Should include post code, phone numbers and provinces.

Attachments (5)

be_localflavor.diff​ (15.1 KB) - added by laurentluce 13 years ago.
be_localflavor.2.diff​ (15.3 KB) - added by laurentluce 13 years ago.
add support for 0xxxxxxxx, 04xxxxxxxx phone number format. Wrap long lines.
be_localflavor.3.diff​ (12.9 KB) - added by laurentluce 13 years ago.
3rd version - add unittests instead of doctests
be_localflavor.4.diff​ (12.9 KB) - added by laurentluce 13 years ago.
minor fix - doc underline too short
be_localflavor.5.diff​ (13.8 KB) - added by laurentluce 13 years ago.
update docs and unit tests for phone number with dots in format as seen in use in Belgium

Download all attachments as: .zip

Change History (14)

comment:1 Changed 13 years ago by laurentluce

Status: new → assigned

comment:2 Changed 13 years ago by laurentluce

Triage Stage: Unreviewed → Accepted

Changed 13 years ago by laurentluce

Attachment: be_localflavor.diff​ added

comment:3 Changed 13 years ago by laurentluce

Has patch: set

patch contains the following:

  • forms.py with BEPostalCodeField, BEPhoneNumberField, BERegionSelect, BEProvinceSelect
  • be_regions.py with the 3 Belgium regions
  • be_provinces.py with the 11 Belgium provinces
  • added tests be.py and updated tests/regressiontests/forms/tests.py

Changed 13 years ago by laurentluce

Attachment: be_localflavor.2.diff​ added

add support for 0xxxxxxxx, 04xxxxxxxx phone number format. Wrap long lines.

comment:4 Changed 13 years ago by Gert Van Gool

One more thing, you might want to switch from doctests to unittests.
It has come up on the mailing list once before in a ​message from Alex.

comment:5 Changed 13 years ago by Russell Keith-Magee

Patch needs improvement: set

We're in the process of trying to purge the doctests from our test suite. We're trying to avoid adding doctests if at all possible, and doctests for completely new functionality are one of those things that are easy to avoid.

Changed 13 years ago by laurentluce

Attachment: be_localflavor.3.diff​ added

3rd version - add unittests instead of doctests

comment:6 Changed 13 years ago by laurentluce

Patch needs improvement: unset
  • Replaced doctests by unittests.
  • Modified tests/regressiontests/forms/tests.py to import BE localflavor unit tests properly
  • Add my name to AUTHORS

comment:7 Changed 13 years ago by Russell Keith-Magee

Triage Stage: Accepted → Ready for checkin

Patch looks good; marking RFC.

Changed 13 years ago by laurentluce

Attachment: be_localflavor.4.diff​ added

minor fix - doc underline too short

Changed 13 years ago by laurentluce

Attachment: be_localflavor.5.diff​ added

update docs and unit tests for phone number with dots in format as seen in use in Belgium

comment:8 Changed 13 years ago by Jannis Leidel

Resolution: → fixed
Status: assigned → closed

(In [14160]) Fixed #14349 -- Added Belgium localflavor. Thanks for the report and patch, Laurent Luce.

comment:9 Changed 12 years ago by Jacob

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top