Paginator does not handle django.db.models.sql.datastructures.EmptyResultSet

[teh]

I'd argue that it should be treated as 0 entries, i.e. the allow_empty_first_page is the proper place to catch this.

Attached patch fixes this.

[Gabriel Hurley]

I'm curious how you got EmptyResultSet into Paginator to begin with... I thought EmptyResultSet was pretty much only used in the Django internals.

That aside, I wonder if adding a __len__ method on EmptyResultSet might be a better option than catching another exception. Treat the problem, not the symptom, right?

Also, you'll need a unit test for the patch, which would be a good way to demonstrate how EmptyResultSet gets into Paginator...

[Alex Gaynor]

EmptyResultSet should never escape the ORM internals, if it is *thats* the bug. And that's what we need a test/patch for.

[oberrocker]

Just a hint (not a test, I'm afraid):

The problem occurred here when I filtered a queryset with __in using an empty list, e.g.

items = Location.objects.filter(zip__in=[])

The resulting queryset is empty, looking ok otherwise, but feeding it into Paginator causes an EmptyResultSet exception.

Using an empty queryset that was returned by a simple filter works as expected, e.g.

items = Location.objects.filter(name="SOIHFODIHFO")

Hope this helps.

Markus

[Claude Paroz]

I tried with a __in=[] filter, but wasn't able to reproduce it. Until you provide us with a real failing test case, I'm closing it. Don't hesitate to reopen if you have some more concrete use case.