Opened 5 years ago

Last modified 10 months ago

#14284 new New feature

Support for Google Maps version 3

Reported by: DaveWP196 Owned by:
Component: GIS Version: master
Severity: Normal Keywords: Google Maps
Cc: alanjds, kmike84@…, rh0dium, mr.kamu@… Triage Stage: Accepted
Has patch: yes Needs documentation: yes
Needs tests: yes Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

Rewrite the javascript files to use Google Maps V3 API rather than Google Maps V2 API. Google deprecated version 2 of the interface on 19 May 2010.

Attachments (3)

14284_patch.diff (20.2 KB) - added by ericpalakovichcarr 5 years ago.
First draft of patch to update from google maps v2 to v3. No testing performed for code.
14284_patch.2.diff (22.3 KB) - added by alanjds 5 years ago.
Improved patch, over 1.2.4
googlemapsv3_r16044.diff (22.0 KB) - added by oyvind 4 years ago.
fixed issue with GImage code generation

Download all attachments as: .zip

Change History (17)

comment:1 Changed 5 years ago by DaveWP196

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 5 years ago by PaulM

  • Triage Stage changed from Unreviewed to Accepted

comment:3 Changed 5 years ago by ericpalakovichcarr

  • Owner changed from nobody to ericpalakovichcarr
  • Status changed from new to assigned

Changed 5 years ago by ericpalakovichcarr

First draft of patch to update from google maps v2 to v3. No testing performed for code.

comment:4 Changed 5 years ago by ericpalakovichcarr

  • Has patch set
  • Needs documentation set
  • Needs tests set
  • Patch needs improvement set

comment:5 Changed 5 years ago by anonymous

Existing (broken) patch improved. Tested over 1.2.4 and working OK.

Needs clean-up of some unneeded settings, but for now this settings remains as noops. Django API keeps the same too.

http://github.com/django/django/pull/16

Changed 5 years ago by alanjds

Improved patch, over 1.2.4

comment:6 Changed 5 years ago by alanjds

  • Cc alanjds added

(last anonymous is me. I forgot to login before comment, sorry)

Changed 4 years ago by oyvind

fixed issue with GImage code generation

comment:7 Changed 4 years ago by julien

  • Severity set to Normal
  • Type set to New feature

comment:8 Changed 4 years ago by kmike

  • Cc kmike84@… added
  • Easy pickings unset
  • UI/UX unset

comment:9 Changed 4 years ago by alanjds

There is any chance for this to be into 1.4 ??
What needs to be done?
I managed to easily port to 1.3.X branch, and I can expect it to be easily ported to 1.4 too.

comment:10 Changed 3 years ago by rh0dium

  • Cc rh0dium added

What is the status of this - How can I help get this in?

comment:11 Changed 2 years ago by Kamu

  • Cc mr.kamu@… added
  • Version changed from 1.2 to master

This ticket should also address ticket #13462.

comment:12 Changed 18 months ago by ericpalakovichcarr

  • Owner ericpalakovichcarr deleted
  • Status changed from assigned to new

comment:13 Changed 10 months ago by reinout

(Working at the djangounderthehood sprint)

The default is now openstreetmap, so most people won't see the problem.

We did verify that the v2 google api is indeed still used in the django/contrib/gis/templates/gis/google/google-maps.js.

Note: https://docs.djangoproject.com/en/dev/ref/contrib/gis/admin/#django.contrib.gis.admin.GeoModelAdmin.map_template does mention you can change the map template, but it doesn't document which template to use for google.

An option could be to remove the google template altogether. Do we want to spend the time fixing the google template?

comment:14 Changed 10 months ago by claudep

It all depends on user's interest. FWIW, I'm not. But if anyone provides a good patch with tests and docs, I'll take the time to review it.

If it is really broken and noone intends to take the time to update it, then yes, it would be better to remove it.

Note: See TracTickets for help on using tickets.
Back to Top