Opened 5 years ago

Closed 2 years ago

#13462 closed Bug (wontfix)

GoogleMaps object should default to version 2 of google maps

Reported by: nbv4 Owned by: EvilDMP
Component: GIS Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: yes UI/UX: no

Description

Currently, the google maps will default to version "2.x" if you do not specify a version in your settings. Version "2.x" is basically the alpha branch of google maps: http://code.google.com/p/gmaps-api-issues/wiki/JavascriptMapsAPIChangelog

It should default to either "2.s" or just "2". Note: the map.setUIToDefault(); method (which GoogleMaps adds by default) does not work in "2.s" (currently), so that would have to be changed if "2.s" is decided on instead.

Attachments (1)

gmaps_version.diff (603 bytes) - added by nbv4 5 years ago.

Download all attachments as: .zip

Change History (13)

Changed 5 years ago by nbv4

comment:1 Changed 5 years ago by russellm

  • Component changed from Uncategorized to GIS
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Design decision needed

comment:2 Changed 5 years ago by Leo

  • Version changed from 1.1 to SVN

nbv4 is right, "2.x" is basically the rough alpha branch. This change should get done independently of #14284.

Whatever support remains for the V2 api should point to either "2" or "2.s"

comment:3 Changed 4 years ago by julien

  • Severity set to Normal
  • Type set to Bug

comment:4 Changed 4 years ago by aaugustin

  • UI/UX unset

Change UI/UX from NULL to False.

comment:5 Changed 4 years ago by aaugustin

  • Easy pickings unset

Change Easy pickings from NULL to False.

comment:6 Changed 2 years ago by aaugustin

  • Triage Stage changed from Design decision needed to Accepted

comment:7 Changed 2 years ago by DjangoPanngo

  • Easy pickings set
  • Needs tests set

Unittest missing and dev comments has to change according to the new code. Other than that, this is ready for checkin.

comment:8 Changed 2 years ago by EvilDMP

  • Owner changed from nobody to EvilDMP
  • Status changed from new to assigned

I have marked this ticket as suitable for a first-time committer attending a Don't be afraid to commit workshop.

The next planned session will be hosted by Cardiff Dev Workshop on Saturday 8th June.

If you want to tackle this ticket before then, or at any time in fact, please don't let the fact that it's assigned to me stop you. Feel free to re-assign it to yourself and do whatever you like to it.

Last edited 2 years ago by EvilDMP (previous) (diff)

comment:9 Changed 2 years ago by Kamu

  • Patch needs improvement set

comment:10 Changed 2 years ago by Kamu

According to the Gmaps API website linked above, the API v2 is deprecated.

Version 2 of the Maps API is deprecated, and is warranted only until 19 May 2013. You are strongly advised to start new projects using Version 3, and to convert existing Version 2 projects to Version 3 as soon as possible. Help on migration is available.

Ticket #14284 should fix this issue.

comment:11 Changed 2 years ago by Kamu

  • Needs tests unset

comment:12 Changed 2 years ago by charettes

  • Resolution set to wontfix
  • Status changed from assigned to closed

Marking as wontfix since v2 will be completely deprecated on November 19, 2013 #14284 should supersede this ticket.

Note: See TracTickets for help on using tickets.
Back to Top