Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#14252 closed (fixed)

django.contrib.flatpages unit tests assume default value for settings.LOGIN_URL

Reported by: Paul McLanahan Owned by: Tobias McNulty
Component: Contrib apps Version: 1.2
Severity: Keywords: flatpages tests
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no
Pull Requests:How to create a pull request

Description

This causes them to break when running from a project's test suite (manage.py test) with the flatpages app installed, if the project sets LOGIN_URL to a non-default value. They would also break when running from Django's test suite with the LOGIN_URL setting non-default.

Change History (6)

by Paul McLanahan, 14 years ago

Attachment: django-flatpages-tests.diff​ added

Proposed fix

comment:1 by Paul McLanahan, 14 years ago

Has patch: set

comment:2 by Tobias McNulty, 14 years ago

Owner: changed from nobody to Tobias McNulty
Status: new → assigned

comment:3 by Tobias McNulty, 14 years ago

Component: Uncategorized → Contrib apps
Triage Stage: Unreviewed → Ready for checkin

Tested and verified that this is an issue and the patch fixes it. Unfortunately the settings hackery is necessary because flatpages provides its own urls.py for tests.

It's a pretty simple change so I'm marking it RFC.

comment:4 by Luke Plant, 14 years ago

Resolution: → fixed
Status: assigned → closed

(In [13851]) Fixed #14252 - django.contrib.flatpages unit tests assume default value for settings.LOGIN_URL

Thanks to pmclanahan for report and patch.

comment:5 by Luke Plant, 14 years ago

(In [13853]) [1.2.X] Fixed #14252 - django.contrib.flatpages unit tests assume default value for settings.LOGIN_URL

Thanks to pmclanahan for report and patch.

Backport of [13851] from trunk

Note: See TracTickets for help on using tickets.
Back to Top