#14252 closed (fixed)
django.contrib.flatpages unit tests assume default value for settings.LOGIN_URL
| Reported by: | Paul McLanahan | Owned by: | Tobias McNulty |
|---|---|---|---|
| Component: | Contrib apps | Version: | 1.2 |
| Severity: | Keywords: | flatpages tests | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
This causes them to break when running from a project's test suite (manage.py test) with the flatpages app installed, if the project sets LOGIN_URL to a non-default value. They would also break when running from Django's test suite with the LOGIN_URL setting non-default.
Attachments (1)
Change History (6)
by , 14 years ago
| Attachment: | django-flatpages-tests.diff added |
|---|
comment:1 by , 14 years ago
| Has patch: | set |
|---|
comment:2 by , 14 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:3 by , 14 years ago
| Component: | Uncategorized → Contrib apps |
|---|---|
| Triage Stage: | Unreviewed → Ready for checkin |
Tested and verified that this is an issue and the patch fixes it. Unfortunately the settings hackery is necessary because flatpages provides its own urls.py for tests.
It's a pretty simple change so I'm marking it RFC.
comment:4 by , 14 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:5 by , 14 years ago
Note:
See TracTickets
for help on using tickets.
Proposed fix