#14012 closed (fixed)
Adding an User object in a popup fails
Reported by: | Owned by: | nobody | |
---|---|---|---|
Component: | contrib.admin | Version: | 1.2 |
Severity: | Keywords: | ||
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Let's say we have a model with a ForeignKey to the django.contrib.auth.User! If you edit objects of this model on the admin interface, you can click the little green plus sign to add a new User in a popup window. You enter the user name and the password (twice). In django 1.1, it closed the window, created the user then set in the select. Django 1.2 behaves wrong, it displays the edit user form, instead of closing the window. You can't even close the window with the full form's save button. To illustrate this, I've uploaded a video:
http://www.youtube.com/watch?v=BIMRoBbH8ws
(The left one is django 1.1.1, the right is django 1.2.1)
Attachments (2)
Change History (17)
comment:1 by , 14 years ago
comment:2 by , 14 years ago
Triage Stage: | Unreviewed → Accepted |
---|
Bisection shows change in behavior was introduced by r12218.
comment:3 by , 14 years ago
Component: | Uncategorized → django.contrib.admin |
---|---|
Has patch: | set |
comment:4 by , 14 years ago
Triage Stage: | Accepted → Ready for checkin |
---|
Marking RFC as per Jacob instructions on IRC.
by , 14 years ago
Attachment: | 14012.2.diff added |
---|
Alternative patch also fixing an (old?) typo 'a username' -> 'an username'
comment:5 by , 14 years ago
Note that both patches uploaded so far introduce and/or change new translatable literal and as such might be acceptable for trunk but not for the 1.2.x branch.
comment:6 by , 14 years ago
"a username" reads correctly to me, "an username" reads wrong. I don't think new/changed translatable strings generally prevent fixes from being applied to a maint. branch -- better to fix the bug and have an untranslated string than not fix the bug at all. And new translations can be provided for the branch....
comment:8 by , 14 years ago
Karen is right. Ignore my comment about not adding translatable literals on a maintenance branch.
comment:9 by , 14 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:10 by , 14 years ago
comment:11 by , 14 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
This does not appear fixed to me. Running from svn and 1.2.5 I was unable to add a user via the popup window for either a manytomany or foreignkey. I get exactly the same behavior as described in the right side video.
comment:13 by , 14 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
This ticket was fixed; the regression is a separate issue to the original problem. I've just opened #15420 to track the regression.
Sorry, the video link is wrong:
http://gk.lka.hu/x/keep/django-add-user-bug.mov