Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#13856 closed (fixed)

missing float:right in change_list, toplinks when using RTL(BIDI)

Reported by: benc Owned by: nobody
Component: contrib.admin Version: 1.2
Severity: Keywords: sprintdec2010
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The following css style is missing from admin_media/css/rtl.css:

.change-list ul.toplinks li {
   float: right
}

When using date_hierarchy = 'created_at' the date navigation is floated to the left
while in rtl it should float to the right.

Maybe it will also fix other things in toplinks.

Thanks

Attachments (1)

13856_rtl_toplinks.diff (458 bytes) - added by julien 5 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 5 years ago by lrekucki

  • Component changed from django-admin.py to django.contrib.admin
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 5 years ago by julien

  • Has patch set
  • Keywords sprintdec2010 added
  • milestone set to 1.3
  • Triage Stage changed from Unreviewed to Accepted

Makes perfect sense. Considering this as a usability bug so marking for 1.3.

Changed 5 years ago by julien

comment:3 Changed 5 years ago by DrMeers

  • Triage Stage changed from Accepted to Ready for checkin

comment:4 Changed 5 years ago by jezdez

  • Resolution set to fixed
  • Status changed from new to closed

(In [14881]) Fixed #13856 -- Float admin's top links on the right for RTL languages.

comment:5 Changed 5 years ago by jezdez

(In [14904]) [1.2.X] Fixed #13856 -- Float admin's top links on the right for RTL languages.

Backport from trunk (r14881).

comment:6 Changed 4 years ago by jacob

  • milestone 1.3 deleted

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top