Opened 15 years ago

Closed 14 years ago

Last modified 13 years ago

#13856 closed (fixed)

missing float:right in change_list, toplinks when using RTL(BIDI)

Reported by: benc Owned by: nobody
Component: contrib.admin Version: 1.2
Severity: Keywords: sprintdec2010
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no
Pull Requests:How to create a pull request

Description

The following css style is missing from admin_media/css/rtl.css:

.change-list ul.toplinks li {
   float: right
}

When using date_hierarchy = 'created_at' the date navigation is floated to the left
while in rtl it should float to the right.

Maybe it will also fix other things in toplinks.

Thanks

Change History (7)

comment:1 by Łukasz Rekucki, 15 years ago

Component: django-admin.py → django.contrib.admin

comment:2 by Julien Phalip, 14 years ago

Has patch: set
Keywords: sprintdec2010 added
milestone: → 1.3
Triage Stage: Unreviewed → Accepted

Makes perfect sense. Considering this as a usability bug so marking for 1.3.

by Julien Phalip, 14 years ago

Attachment: 13856_rtl_toplinks.diff​ added

comment:3 by Simon Meers, 14 years ago

Triage Stage: Accepted → Ready for checkin

comment:4 by Jannis Leidel, 14 years ago

Resolution: → fixed
Status: new → closed

(In [14881]) Fixed #13856 -- Float admin's top links on the right for RTL languages.

comment:5 by Jannis Leidel, 14 years ago

(In [14904]) [1.2.X] Fixed #13856 -- Float admin's top links on the right for RTL languages.

Backport from trunk (r14881).

comment:6 by Jacob, 13 years ago

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top