Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#13853 closed (fixed)

line with csrf_token too wide

Reported by: Alper Cugun Owned by: anonymousD
Component: Documentation Version: 1.2
Severity: Keywords: minor
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

I missed this csrf_token the first time around because the line is too wide causing some frustration.

Here's the fix.

Cheers,
Alper

Attachments (2)

auth_doc.diff (547 bytes) - added by Alper Cugun 6 years ago.
fix
13853_2.diff (583 bytes) - added by Richard Barran 6 years ago.
Same patch, but with a 'svn diff' run from the project root.

Download all attachments as: .zip

Change History (7)

Changed 6 years ago by Alper Cugun

Attachment: auth_doc.diff added

fix

comment:1 Changed 6 years ago by anonymous

Needs documentation: unset
Needs tests: unset
Owner: changed from nobody to anonymousD
Patch needs improvement: unset

comment:2 Changed 6 years ago by Richard Barran

Triage Stage: UnreviewedAccepted

Change works for me.
Alper - it looks like you've created your patch by running a diff in the directory of the file that's been changed. It's a bit easier to apply the patch if you run a diff from the top-level trunk directory.
I'm uploading a new patch 13853_2.diff which is exactly the same as yours, except that I ran it from the top-level trunk directory.

Changed 6 years ago by Richard Barran

Attachment: 13853_2.diff added

Same patch, but with a 'svn diff' run from the project root.

comment:3 Changed 6 years ago by Tim Graham

Summary: line too wideline with csrf_token too wide
Triage Stage: AcceptedReady for checkin

comment:4 Changed 6 years ago by Luke Plant

Resolution: fixed
Status: newclosed

(In [13688]) Fixed #13853 - line with csrf_token too wide

Thanks to alper for report, alper/richardb for patch

comment:5 Changed 6 years ago by Luke Plant

(In [13691]) [1.2.X] Fixed #13853 - line with csrf_token too wide

Thanks to alper for report, alper/richardb for patch

Backport of [13688] from trunk.

Note: See TracTickets for help on using tickets.
Back to Top