Opened 6 years ago

Closed 4 years ago

#13838 closed New feature (invalid)

Enhancements to Japanese localflavor module

Reported by: Ian Lewis Owned by: nobody
Component: contrib.localflavor Version: 1.2
Severity: Normal Keywords: localflavorsplit
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: yes
Needs tests: yes Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

This is a patch for the Japanese localflavor module that fixes a long standing problem with the ordering of the JPPrefectureSelect widget and adds new form fields for doing common validation on Japanese text.

Attachments (1)

localflavor_jp.patch (10.4 KB) - added by Ian Lewis 6 years ago.
A patch that enhances the Japanese localflavor module.

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by Ian Lewis

Attachment: localflavor_jp.patch added

A patch that enhances the Japanese localflavor module.

comment:1 Changed 6 years ago by Russell Keith-Magee

Needs documentation: set
Patch needs improvement: set
Triage Stage: UnreviewedAccepted

Patch needs to be updated to use unittests, not doctests, and requires documentation of the new features. Once that change has been made, feel free to bump to ready to checkin.

Unfortunately, this has just missed the 1.3 feature freeze, so we can't add the new form fields for the 1.3 release. However, the prefecture re-organization can be handled as a bugfix, so if you split that into a separate ticket and patch, that can be included for 1.3.

comment:2 Changed 6 years ago by Graham King

Severity: Normal
Type: New feature

comment:3 Changed 5 years ago by Jannis Leidel

Easy pickings: unset
Needs tests: set
UI/UX: unset

comment:4 Changed 4 years ago by Aymeric Augustin

Keywords: localflavorsplit added
Resolution: invalid
Status: newclosed

django.contrib.localflavor is now deprecated — see https://docs.djangoproject.com/en/dev/ref/contrib/localflavor/

A repository was created for each localflavor at https://github.com/django/django-localflavor-? (Replace with the country code.)

If you're still interested in this ticket, could you create a pull request on that repository?

Sorry for not resolving this issue earlier, and thanks for your input!

Note: See TracTickets for help on using tickets.
Back to Top