Code

Opened 4 years ago

Closed 18 months ago

#13838 closed New feature (invalid)

Enhancements to Japanese localflavor module

Reported by: IanLewis Owned by: nobody
Component: contrib.localflavor Version: 1.2
Severity: Normal Keywords: localflavorsplit
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: yes
Needs tests: yes Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

This is a patch for the Japanese localflavor module that fixes a long standing problem with the ordering of the JPPrefectureSelect widget and adds new form fields for doing common validation on Japanese text.

Attachments (1)

localflavor_jp.patch (10.4 KB) - added by IanLewis 4 years ago.
A patch that enhances the Japanese localflavor module.

Download all attachments as: .zip

Change History (5)

Changed 4 years ago by IanLewis

A patch that enhances the Japanese localflavor module.

comment:1 Changed 3 years ago by russellm

  • Needs documentation set
  • Needs tests unset
  • Patch needs improvement set
  • Triage Stage changed from Unreviewed to Accepted

Patch needs to be updated to use unittests, not doctests, and requires documentation of the new features. Once that change has been made, feel free to bump to ready to checkin.

Unfortunately, this has just missed the 1.3 feature freeze, so we can't add the new form fields for the 1.3 release. However, the prefecture re-organization can be handled as a bugfix, so if you split that into a separate ticket and patch, that can be included for 1.3.

comment:2 Changed 3 years ago by graham_king

  • Severity set to Normal
  • Type set to New feature

comment:3 Changed 3 years ago by jezdez

  • Easy pickings unset
  • Needs tests set
  • UI/UX unset

comment:4 Changed 18 months ago by aaugustin

  • Keywords localflavorsplit added
  • Resolution set to invalid
  • Status changed from new to closed

django.contrib.localflavor is now deprecated — see https://docs.djangoproject.com/en/dev/ref/contrib/localflavor/

A repository was created for each localflavor at https://github.com/django/django-localflavor-? (Replace with the country code.)

If you're still interested in this ticket, could you create a pull request on that repository?

Sorry for not resolving this issue earlier, and thanks for your input!

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.