Code

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#13798 closed (fixed)

Add an argument to connection_created signal to distinguish connections in a multi-db environment

Reported by: liangent Owned by: nobody
Component: Database layer (models, ORM) Version: 1.2
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

[10182] introduced connection_created signal. In a single-db environment, using django.db.connection is ok; in a multi-db environment, it's necessary to add an argument to indicate the connection being created. Either a connection name or a connection object is acceptable for me.

Attachments (1)

django-connection-created.diff (8.9 KB) - added by Alex 4 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 4 years ago by Alex

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Changed 4 years ago by Alex

comment:2 Changed 4 years ago by Joshua Ginsberg <jag@…>

  • Has patch set

comment:3 Changed 4 years ago by robhudson

Patch should add or update the docs for the connection_created signal filed in bug #14054

comment:4 Changed 4 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [13672]) Fixed #13798 -- Added connection argument to the connection_created signal. Thanks to liangent for the report, and Alex Gaynor for the patch.

comment:5 Changed 4 years ago by russellm

(In [13674]) [1.2.X] Fixed #13798 -- Added connection argument to the connection_created signal. Thanks to liangent for the report, and Alex Gaynor for the patch.

Backport of r13672 from trunk.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.