#13510 closed (fixed)
Row level errors on ModelForms in the admin mess up colspans
| Reported by: | KyleMac | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.admin | Version: | dev |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Row level errors on ModelForms in the admin have their colspan set based on the number of fields on the model rather than what are actually being displayed in the admin, i.e. it doesn't take into account editable=False (and maybe excludes too). This can lead to the some display issues.
Also when row level errors are displayed the colspan on the "add another" row reverts to 1.
A screenshot shows it best.
Attachments (2)
Change History (8)
by , 14 years ago
| Attachment: | django admin.png added |
|---|
comment:1 by , 14 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
by , 13 years ago
| Attachment: | 13510_tabular_inline_errors_colspan.diff added |
|---|
comment:2 by , 13 years ago
| Has patch: | set |
|---|---|
| milestone: | → 1.3 |
comment:5 by , 13 years ago
I couldn't reproduce the Colspan on the "Add another" button row reverting to 1 issue. If you still see it, please open another ticket with more detailed instructions on how to reproduce it.
Note:
See TracTickets
for help on using tickets.
In fact here the colspan should be 4, not 3 (there's an invisible cell containing a hidden field). The attached patch should fix this problem.