Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#13509 closed (fixed)

PyPy/Jython fix for comment tests

Reported by: Alex Gaynor Owned by: nobody
Component: Testing framework Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Truth be told my instinct is there are more of these in there, but this is all I could reproduce. We're again leaving a signal dangling, assuming the weakref will die immediately.

Attachments (1)

django-pypy.diff (1000 bytes) - added by Alex Gaynor 6 years ago.

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by Alex Gaynor

Attachment: django-pypy.diff added

comment:1 Changed 6 years ago by Russell Keith-Magee

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

comment:2 Changed 6 years ago by Russell Keith-Magee

Resolution: fixed
Status: newclosed

(In [13204]) Fixed #13509 -- Modified the comment tests so that signal cleanup doesn't rely on garbage collection. Thanks to Alex Gaynor for the report and patch.

comment:3 Changed 6 years ago by Russell Keith-Magee

(In [13206]) [1.1.X] Fixed #13509 -- Modified the comment tests so that signal cleanup doesn't rely on garbage collection. Thanks to Alex Gaynor for the report and patch.

Backport of r13204 from trunk.

comment:4 Changed 5 years ago by Jacob

milestone: 1.2

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top