Code

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#13509 closed (fixed)

PyPy/Jython fix for comment tests

Reported by: Alex Owned by: nobody
Component: Testing framework Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Truth be told my instinct is there are more of these in there, but this is all I could reproduce. We're again leaving a signal dangling, assuming the weakref will die immediately.

Attachments (1)

django-pypy.diff (1000 bytes) - added by Alex 4 years ago.

Download all attachments as: .zip

Change History (5)

Changed 4 years ago by Alex

comment:1 Changed 4 years ago by russellm

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 4 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [13204]) Fixed #13509 -- Modified the comment tests so that signal cleanup doesn't rely on garbage collection. Thanks to Alex Gaynor for the report and patch.

comment:3 Changed 4 years ago by russellm

(In [13206]) [1.1.X] Fixed #13509 -- Modified the comment tests so that signal cleanup doesn't rely on garbage collection. Thanks to Alex Gaynor for the report and patch.

Backport of r13204 from trunk.

comment:4 Changed 3 years ago by jacob

  • milestone 1.2 deleted

Milestone 1.2 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.