Wrong behavior for textarea tag render

[William Grzybowski]

The Textarea widget is rendering textarea tag like this:

return mark_safe(u'<textarea%s>%s</textarea>' % (flatatt(final_attrs),
                conditional_escape(force_unicode(value))))

However this is not the expected behavior for textarea tag, as from W3C[1] this should be:

<textarea>
first line
</textarea>

So the correct render should be:

return mark_safe(u'<textarea%s>\n%s\n</textarea>' % (flatatt(final_attrs),
                conditional_escape(force_unicode(value))))

[1] ​http://www.w3.org/TR/html401/interact/forms.html#edef-TEXTAREA

[Ramiro Morales]

(reformatted description)

[Russell Keith-Magee]

I don't see anything in the reference you provide that requires that there be newlines inside the definition of a TEXTAREA, and I haven't seen any evidence that Django's rendering causes problems in any browers in practice.

[William Grzybowski]

Sorry i forgot to mention.

The problem is like this:

• Write a text using the widget Textarea starting with a newline, like: "\n My text here"
• Save it
• Come back to edit the saved the

You will not see the blank line in the start of the textarea

[Russell Keith-Magee]

Ok. I see what you're driving at now. However, it looks to me like only the first \n is required; if you have the trailing \n, you end up padding your submissions.

Tests are also required.

[William Grzybowski]

Textarea render

[William Grzybowski]

OK.

Patch reworked with heading \n.
Tested ok here, tell me if there is anything else to do, i am new here :)

[William Grzybowski]

textarea patch for svn trunk

[Gabriel Hurley]

FYI, by "tests are also required" Russell meant a regression test for the test suite (i.e. a unit test/doctest). That's what the "needs tests" checkbox on the ticket is for.

[Anssi Kääriäinen]

patch with tests

[anonymous]

Textarea tag should be rendered with cols="" and rows="" attributes, because it's needed by W3C validation.
I think it is obligate, event if those attributes are to be set to empty value.

[patchhammer]

ticket13385.patch fails to apply cleanly on to trunk

[Claude Paroz]

Patch updated to current trunk

[Claude Paroz]

Duplicate of #8627, which has just been fixed.