Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#13374 closed (fixed)

A few more small PyPy issues

Reported by: Alex Owned by: nobody
Component: Uncategorized Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

First one is just a differing repr in the tests (pypy includes a module name, cpython doesn't), second is a GC issue.

Attachments (1)

django-pypy.diff (4.4 KB) - added by Alex 5 years ago.

Download all attachments as: .zip

Change History (8)

Changed 5 years ago by Alex

comment:1 Changed 5 years ago by Alex

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 5 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [12998]) Fixed #13374 -- Corrected some more minor issues causing problems for PyPy. Thanks to Alex Gaynor for the report and patch.

comment:3 Changed 5 years ago by russellm

(In [12999]) [1.1.X] Fixed #13374 -- Corrected some more minor issues causing problems for PyPy. Thanks to Alex Gaynor for the report and patch.

Backport of r12998 from trunk.

comment:4 Changed 5 years ago by kmtracey

  • Has patch unset
  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Triage Stage changed from Ready for checkin to Accepted

The change to regressiontests/forms/localflavor/se.py broke the running of the __test__ dictionary doctests specified in regressiontests/forms/tests.py, so I've reverted it in r13008. There must be a better way to fix PyPy compatibility for this test...?

comment:5 Changed 5 years ago by Alex

The fix will be to do date.today() == date(expected, stuff, here); >>> True .

comment:6 Changed 5 years ago by russellm

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [13010]) Fixed #13374 -- Modified a test so that it can pass under PyPy. This is a reimplementation of part of r12998, reverted in r13008. Thanks to Alex Gaynor.

comment:7 Changed 4 years ago by jacob

  • milestone 1.2 deleted

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top