Code

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#13345 closed (fixed)

error message when runing test suite after [12950]

Reported by: ramiro Owned by: nobody
Component: Testing framework Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The django test suite has, besides all the regression tests, a tests/regressiontests/locale data directory used in tests that exercise the ability to override apps translations with project translations (this was added for 1.2).

When running the site, the app loader generates a non-fatal error after r12950 similar to the one if generates when if finds leftover dirs in a SVN WC containing .pyc after test shuffling in the repo:

Error while importing locale:  File "./runtests.py", line 135, in django_tests
    mod = load_app(model_label)
  File "/home/r/django/trunk/django/db/models/loading.py", line 75, in load_app
    app_module = import_module(app_name)
  File "/home/r/django/trunk/django/utils/importlib.py", line 35, in import_module
    __import__(name)
ImportError: No module named locale

This can also be seen in the buildbot output.

The patch fixes this my simply skipping the directory when looping over the regressiontests/ dir.

Attachments (1)

13345.diff (1.1 KB) - added by ramiro 4 years ago.

Download all attachments as: .zip

Change History (5)

Changed 4 years ago by ramiro

comment:1 Changed 4 years ago by jezdez

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Summary changed from eorro message when runing test suite after [12950] to error message when runing test suite after [12950]

comment:2 Changed 4 years ago by kmtracey

  • Resolution set to fixed
  • Status changed from new to closed

(In [12971]) Fixed #13345: Don't attempt to load the locale regressiontests subdirectory as a Django app. Thanks ramiro.

comment:3 Changed 4 years ago by kmtracey

(In [12987]) [1.1.X] Fixed #13345: Don't attempt to load the locale regressiontests subdirectory as a Django app. Thanks ramiro.
r12971 from trunk.

comment:4 Changed 3 years ago by jacob

  • milestone 1.2 deleted

Milestone 1.2 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.