Code

Opened 4 years ago

Closed 13 months ago

#13344 closed Bug (wontfix)

Name collision for "next" template variable between contrib.comments and views.generic.list_detail

Reported by: erik Owned by: nobody
Component: contrib.comments Version: 1.2-beta
Severity: Normal Keywords:
Cc: Triage Stage: Design decision needed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Both the comment system (in post_comment and it's accompagnying forms) and the generic views system (in views.generic.list_detail's legacy template context stuff) use a template variabled named "next". The comment app's templates approve.html, delete.html, flag.html and preview.html render a hidden form field if next is not empty.

If you use for example the list_detail view with a template which renders a comment form for each list item, the comment form wrongly uses the next-value from the list_details view (the next page number). On posting the comment the user get's an 404 error, because the post_comment view now tries to redirect to a wrong URL containing the next page number.

Maybe it's generally a bad idea to use very simple context variable names like next in prepackaged apps.

Attachments (1)

13344.diff (5.3 KB) - added by erik 4 years ago.
Patch renaming the template variable to "post_comment_next". comment_tests ran successfully.

Download all attachments as: .zip

Change History (7)

Changed 4 years ago by erik

Patch renaming the template variable to "post_comment_next". comment_tests ran successfully.

comment:1 Changed 4 years ago by russellm

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Design decision needed

comment:2 Changed 3 years ago by julien

  • Component changed from Contrib apps to django.contrib.comments

comment:3 Changed 3 years ago by julien

  • Severity set to Normal
  • Type set to Bug

comment:4 Changed 2 years ago by aaugustin

  • UI/UX unset

Change UI/UX from NULL to False.

comment:5 Changed 2 years ago by aaugustin

  • Easy pickings unset

Change Easy pickings from NULL to False.

comment:6 Changed 13 months ago by jacob

  • Resolution set to wontfix
  • Status changed from new to closed

django.contrib.comments has been deprecated and is no longer supported, so I'm closing this ticket. We're encouraging users to transition to a custom solution, or to a hosted solution like Disqus.

The code itself has moved to https://github.com/django/django-contrib-comments; if you want to keep using it, you could move this bug over there.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.