Code

Opened 4 years ago

Closed 4 years ago

#13294 closed (invalid)

Worked in full.html into Notifications application

Reported by: richard@… Owned by: nobody
Component: Uncategorized Version: 1.1
Severity: Keywords: notification html
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Django notifications 0.1.4 has the basic plumbing to send HTML emails with the full.html template that can be over-ridden, but it isn't being used at the moment and doesn't appear to be in 0.1.5 either.

Although the html_mailer app is in alpha (http://recurser.com/code/p/django-html-mailer/), it works like a dream and allows the sending of plain-text and HTML emails. I've basically amended the notification send_now method to include an HTML version if the app is installed. Otherwise, just send the notification as normal.

I've attached my amended models.py file. It does also require the presence of an email_body.html file that is used for rendering the notice's full.html, so I've included a basic HTML version of email_body.txt. It'd be great to see this in and I think this completes the functionality hinted at with full.html.

Attachments (2)

empty_body.html (251 bytes) - added by richard@… 4 years ago.
base template used for all notifications that use the full.html template
models.py (14.9 KB) - added by richard@… 4 years ago.
Amended models.py that uses HTML Mailer application if it is installed

Download all attachments as: .zip

Change History (4)

Changed 4 years ago by richard@…

base template used for all notifications that use the full.html template

Changed 4 years ago by richard@…

Amended models.py that uses HTML Mailer application if it is installed

comment:1 Changed 4 years ago by anonymous

  • Has patch unset
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 4 years ago by lukeplant

  • Resolution set to invalid
  • Status changed from new to closed

This is the tracker for Django, not Django notifications or any other third party app.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.