Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#13293 closed (fixed)

r12900 breaks extra() with additional select clauses (Only applies to MySQL SQLCompiler)

Reported by: Matthias Kestenholz Owned by: nobody
Component: Database layer (models, ORM) Version: master
Severity: Keywords: MySQL
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description (last modified by Ramiro Morales)

[12900] breaks the following query:

Page.objects.filter(...).extra(select={'_url_length': 'LENGTH(_cached_url)'}).order_by('-_url_length')[0]

LENGTH(_cached_url) is prepended to the list of fields which should be selected, which makes the row tuple one element longer than the fields tuple:

http://code.djangoproject.com/browser/django/trunk/django/db/backends/mysql/compiler.py#L6

Note that this bug only manifests itself under the following conditions:

  1. The first model field is an AutoField
  2. The second field is a (Null)?BooleanField
  3. The retrieved model has a PK of 1L (0L would also work, but auto incrementing primary key fields never have a value of 0L)

The resulting model instance has True instead of 1L as its PK.

Attachments (1)

13293.patch (2.2 KB) - added by Matthias Kestenholz 6 years ago.
Now with a regression test

Download all attachments as: .zip

Change History (6)

Changed 6 years ago by Matthias Kestenholz

Attachment: 13293.patch added

Now with a regression test

comment:1 Changed 6 years ago by Matthias Kestenholz

Has patch: set
Keywords: MySQL added
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Summary: r12900 breaks extra() with additional select clausesr12900 breaks extra() with additional select clauses (Only applies to MySQL SQLCompiler)

comment:2 Changed 6 years ago by Ramiro Morales

Description: modified (diff)

(reformatted description)

comment:3 Changed 6 years ago by Russell Keith-Magee

Triage Stage: UnreviewedAccepted

comment:4 Changed 6 years ago by Russell Keith-Magee

Resolution: fixed
Status: newclosed

(In [12939]) Fixed #13293 -- Corrected a problem with the MySQL handling of boolean return values when a query has an extra() clause. Thanks to mk for the report and draft patch.

comment:5 Changed 5 years ago by Jacob

milestone: 1.2

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top