Reverse should ignore unused kwargs like Python string interpolation

[trey@…]

Python does a good job ignoring unused kwargs with string formatting, django should as well.

url(r'^member/(?P<id>\d+)/$', 'edit', name="edit"),

reverse('edit', kwargs={'id': 3}) #SUCCESS
reverse('edit', kwargs={'id': 3, 'random key': 'stuff'}) #FAILS

[Alex Gaynor]

I think better would be to require that the RHS set is a strict superset of the LHS set.

[anonymous]

second patch makes sure params is a subset of kwargs. This is officially a one character change :)

[trey@…]

PS: anonymous posts are me

[trey@…]

3rd diff should work a lot better, we don't want to skip if the sets are equal. My logic was a bit twisted, should be good now though.

[Russell Keith-Magee]

I disagree that this would be a good thing. For example, this could give you the impression that you are reversing to a view that will honor to 'random key', when in fact the argument will be silently ignored.

If you want to argue your case for this, open a discussion on django-developers.