Make reverse() match the behavior of resolve()

[Patryk Zawadzki]

Consider the following urls.py:

urlpatterns = patterns('',
    (r'^faq/$', 'django.views.generic.simple.direct_to_template', {'template': 'faq.html'}, 'faq'),
    (r'^tos/$', 'django.views.generic.simple.direct_to_template', {'template': 'tos.html'}, 'tos'),
)

When passed to resolve(), /faq/ will yield:

>>> resolve('/faq/')
(<function direct_to_template at 0x8b2679c>, (), {'template': 'faq.html'})

However this will raise an exception:

>>> reverse('django.views.generic.simple.direct_to_template', kwargs={'template': 'faq.html'})
NoReverseMatch: Reverse for 'django.views.generic.simple.direct_to_template' with arguments '()' and keyword arguments '{'template': 'faq.html'}' not found.

The attached patch makes reverse() behave more intuitively and return a match when both the key and value match the default kwargs.

>>> reverse('django.views.generic.simple.direct_to_template', kwargs={'template': 'faq.html'})
'/faq/'

[Patryk Zawadzki]

Proposed patch

[Patryk Zawadzki]

I'd provide a test but there is a line in tests/regressiontests/urlpatterns_reverse/urls.py that breaks it:

    url(r'^hardcoded/$', 'hardcoded/', empty_view, name="hardcoded"),

I am not quite sure how to interpret that line but it assigns the view to the kwargs. What should I do about it?

[Russell Keith-Magee]

@patrys -- I can't think of any reason that you would need to pass the view as the kwargs, and if you remove the second 'hardcoded/' argument, the test suite still passes. I'm going to chalk this one up to a bug that didn't get caught because the existing reverse logic didn't walk that particular code path, and there is nothing in the urlpatterns_reverse tests that actually tries to use the view.

Feel free to correct that test as part of your patch for this ticket.

[Patryk Zawadzki]

Tests, assuming that the mentioned URL can be fixed

[Patryk Zawadzki]

Forgot that Trac doesn't send upload notifications. I've attached the tests and fixed the hardcoded/ one as suggested.

[Michał Sałaban]

Can we have this patch applied to 1.3? This change is backwards-compatible and very useful too.

[patchhammer]

django-smarter-reverse-tests.patch fails to apply cleanly on to trunk

[Patryk Zawadzki]

Updated patch containing both the change and the tests

[Patryk Zawadzki]

Updated the patch to apply to current SVN trunk.

[Jannis Leidel]

In [16177]:

Fixed #13154 -- Fixed the URL resolver's reverse() to match the behavior of its resolve() with regard to the default kwargs. Many thanks to patrys.