Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#13107 closed (fixed)

model_formsets test fails to validate models

Reported by: loewis Owned by: nobody
Component: Uncategorized Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Running model_formsets in r12773 gives

Error: One or more models did not validate:
model_formsets.bookwithcustompk: "my_pk": DecimalFields require a "decimal_places" attribute that is a positive integer.

Change History (3)

comment:1 Changed 5 years ago by kmtracey

  • milestone set to 1.2
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

This validation was added in r12768/r12769. The model it is complaining about has a decimal_places arg set to 0. 0 seems like a valid value to me so I think it's the new validation that is broken.

comment:2 Changed 5 years ago by kmtracey

  • Resolution set to fixed
  • Status changed from new to closed

(In [12774]) Fixed #13107: Adjusted decimal_places validation to accept 0 as a valid value. Thanks to loewis for report.

comment:3 Changed 3 years ago by jacob

  • milestone 1.2 deleted

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top