Opened 7 years ago

Closed 6 years ago

Last modified 5 years ago

#13051 closed (fixed)

reversing namespaces doesn't work according to the docs.

Reported by: Florian Apolloner Owned by: Gabriel Hurley
Component: Documentation Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

according to http://docs.djangoproject.com/en/1.1/topics/http/urls/#url-namespaces point 4, django should take the first deployed instance if there is no current_app defin ed (and no default app). Currently it takes the last. The attached patch fixes it. Note: Tests did test this behavior, but they acciendently tested for the last instance.

Attachments (2)

ns.diff (2.5 KB) - added by Florian Apolloner 7 years ago.
13051_docs_patch.diff (1.3 KB) - added by Gabriel Hurley 7 years ago.
patches docs instead of changing code behavior

Download all attachments as: .zip

Change History (9)

Changed 7 years ago by Florian Apolloner

Attachment: ns.diff added

comment:1 Changed 7 years ago by Russell Keith-Magee

Component: UncategorizedDocumentation
Needs documentation: unset
Needs tests: unset
Patch needs improvement: set
Triage Stage: UnreviewedAccepted

Accepted, but I'm inclined to say the problem here is actually the documentation. The current implementation is in the wild, and the current behavior is explicitly tested. Ultimately, the decision of whether you use the first or the last instance is arbitrary; in the interests of minimal impact on deployed instances, I'm inclined to say we fix the documentation to reflect what the implementation actually does.

comment:2 Changed 7 years ago by Gabriel Hurley

Owner: changed from nobody to Gabriel Hurley
Status: newassigned

I'll write up a patch for the docs here in a minute.

Changed 7 years ago by Gabriel Hurley

Attachment: 13051_docs_patch.diff added

patches docs instead of changing code behavior

comment:3 Changed 7 years ago by Gabriel Hurley

Patch needs improvement: unset

comment:4 Changed 6 years ago by Russell Keith-Magee

Triage Stage: AcceptedReady for checkin

comment:5 Changed 6 years ago by Russell Keith-Magee

Resolution: fixed
Status: assignedclosed

(In [13161]) Fixed #13051 -- Corrected the documentation of URL namespacing to match the tested implementation behavior. Thanks to apollo13 for the report, and Gabriel Hurley for the patch.

comment:6 Changed 6 years ago by Russell Keith-Magee

(In [13164]) [1.1.X] Fixed #13051 -- Corrected the documentation of URL namespacing to match the tested implementation behavior. Thanks to apollo13 for the report, and Gabriel Hurley for the patch.

Backport of r13161 from trunk.

comment:7 Changed 5 years ago by Jacob

milestone: 1.2

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top