Opened 7 years ago

Closed 6 years ago

Last modified 5 years ago

#12803 closed (fixed)

Provide styling for warning and error messages

Reported by: Beat Bolli Owned by: Simon Meers
Component: contrib.admin Version: 1.2-beta
Severity: Keywords: admin messages icons
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The new contrib.messages framework provides for different message levels. The admin interface styles all of them in the same way, with an "OK" icon. This patch adds some distinguishing styling for warning and error messages.

Attachments (2)

message-style.diff (1.4 KB) - added by Beat Bolli 7 years ago.
CSS and template patch
admin_message_icons.diff (1.2 KB) - added by Simon Meers 7 years ago.
DRYer CSS, alternate icon for warnings (though maybe less visual emphasis)

Download all attachments as: .zip

Change History (11)

Changed 7 years ago by Beat Bolli

Attachment: message-style.diff added

CSS and template patch

comment:1 Changed 7 years ago by Beat Bolli

Sorry, this is a Git patch that needs to be applied with patch -p1.

comment:2 Changed 7 years ago by Alex Gaynor

Triage Stage: UnreviewedAccepted

Changed 7 years ago by Simon Meers

Attachment: admin_message_icons.diff added

DRYer CSS, alternate icon for warnings (though maybe less visual emphasis)

comment:3 Changed 7 years ago by Simon Meers

Cc: drmeers@… added
Keywords: admin messages icons added

(was just about to submit this as a new issue, but found this one with an almost identical patch)

comment:4 Changed 7 years ago by James Bennett

milestone: 1.21.3

This is really a feature request, and so can't go on 1.2.

comment:5 in reply to:  4 Changed 7 years ago by Simon Meers

Replying to ubernostrum:

This is really a feature request, and so can't go on 1.2.

Couldn't preventing error messages from being displayed with a green tick be considered a bugfix?! Plus the patch is dead simple...

comment:6 Changed 7 years ago by Simon Meers

Cc: drmeers@… removed
Owner: changed from nobody to Simon Meers
Status: newassigned

comment:7 Changed 6 years ago by Luke Plant

Resolution: fixed
Status: assignedclosed

(In [13393]) Fixed #12803 - Added styling for 'error' and 'warning' messages in admin.

Thanks to bboli and sebastian_noack for the report, DrMeers for the patch.

comment:8 Changed 6 years ago by Luke Plant

(In [13394]) [1.2.X] Fixed #12803 - Added styling for 'error' and 'warning' messages in admin.

Thanks to bboli and sebastian_noack for the report, DrMeers for the patch.

Backport of [13393] from trunk. Considered a bug (and therefore backported)
due to error and warning messages being styled with green tick previously.

comment:9 Changed 5 years ago by Jacob

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top