Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#12802 closed (fixed)

InlineModelAdmin.form: inlineformset_factory, not formset_factory

Reported by: rctay Owned by: unbracketed
Component: Documentation Version: 1.1
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The documentation for the form member of !InlineModelAdmin writes that formset_factory is invoked.

As line 1160 of django/contrib/admin/options.py reads, it is inlineformset_factory that is invoked, not formset_factory.

Attachments (1)

12802_update_doc.diff (480 bytes) - added by unbracketed 5 years ago.
Changes formset_factory to inlineformset_factory

Download all attachments as: .zip

Change History (5)

comment:1 Changed 5 years ago by unbracketed

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to unbracketed
  • Patch needs improvement unset
  • Status changed from new to assigned

Changed 5 years ago by unbracketed

Changes formset_factory to inlineformset_factory

comment:2 Changed 5 years ago by unbracketed

  • Has patch set
  • Triage Stage changed from Unreviewed to Ready for checkin

I verified that the form is indeed passed to in django.contrib.admin.options at the last line of InlineModelAdmin.get_formset (currently L1230).

The patch updates the documentation accordingly.

comment:3 Changed 5 years ago by jbronn

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [12528]) Fixed #12802 -- Specify the correct factory in the InlineModelAdmin docs. Thanks, rctay and unbracketed.

comment:4 Changed 5 years ago by jbronn

(In [12529]) [1.1.X] Fixed #12802 -- Specify the correct factory in the InlineModelAdmin docs. Thanks, rctay and unbracketed.

Backport of r12527 from trunk.

Note: See TracTickets for help on using tickets.
Back to Top