Test client doesn't set WSGIRequest instance on response

[rvdrijst]

When you call get() or post() on the Client instance in a testcase, the returned response contains a request attribute that is a simple dict created by the client to simulate a request. This can be useful, but it is not the request instance that is used in views and middleware.

It would be very useful to have the request instance as seen (and possibly modified) by the view and middleware. This is the WSGIRequest instance created in the ClientHandler, used by the Client. This instance is based on the simple dict that is currently set on the response as the request.

I came across this problem before and worked around it, but now with the new messages framework, a clear usecase presents itself. You cannot get to the messages set by a tested view, simply because the response.request is not the WSGIRequest instance that was used for setting the messages.

A (backwards compatible) solution is to let the ClientHandler add this WSGIRequest instance as an attribute called wsgi_request to the response before it returns it.

Using this solution, you can get to the message storage by doing messages.get_messages(response.wsgi_request). It can also be useful for testing middleware, decorators and other functionalities that modify the request in any way.

Attached is the extremely simple patch that makes this one-line addition.

[rvdrijst]

adds the wsgi_request to the client response

[Aymeric Augustin]

Change UI/UX from NULL to False.

[Aymeric Augustin]

Change Easy pickings from NULL to False.

[Unai Zalakain]

This would solve the problems mentioned in https://code.djangoproject.com/ticket/15179#comment:24

[Unai Zalakain]

PR sent: ​https://github.com/django/django/pull/1942

[Tim Graham <timograham@…>]

In 9eb16031ca837624433c49646289b50f9566a25d:

Fixed #12571 -- Attached originating WSGIRequest to test client responses.

Originating WSGIRequests are now attached to the wsgi_request attribute of
the HttpResponse returned by the testing client.

Thanks rvdrijst for the suggestion.