BaseGenericInlineFormSet has unused members
|Reported by:||Lars van de Kerkhof||Owned by:||nobody|
|Severity:||Keywords:||contenttypes unused code BaseGenericInlineFormSet|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
BaseGenericInlineFormSet has 2 members which are never changed or referenced by any code. This is confusing other developers. For example in django-reversion there used to be a bug in which the name of the content type foreign key, was determined by ct_fk_field_name instead of ct_fk_field.name. ct_fk_field_name is one of the unused members.
Code that is never used should be removed to avoid confusion.
Please see attached patched against current trunk.
Change History (6)
comment:1 Changed 7 years ago by
|Patch needs improvement:||unset|
|Triage Stage:||Unreviewed → Accepted|