#12570 closed (fixed)
BaseGenericInlineFormSet has unused members
Reported by: | Lars van de Kerkhof | Owned by: | nobody |
---|---|---|---|
Component: | Contrib apps | Version: | 1.2-alpha |
Severity: | Keywords: | contenttypes unused code BaseGenericInlineFormSet | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
BaseGenericInlineFormSet has 2 members which are never changed or referenced by any code. This is confusing other developers. For example in django-reversion there used to be a bug in which the name of the content type foreign key, was determined by ct_fk_field_name instead of ct_fk_field.name. ct_fk_field_name is one of the unused members.
Code that is never used should be removed to avoid confusion.
Please see attached patched against current trunk.
Attachments (1)
Change History (6)
by , 15 years ago
Attachment: | basegenricinlineformset_unused_code_removed.diff added |
---|
comment:1 by , 15 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:2 by , 15 years ago
Component: | Uncategorized → Contrib apps |
---|
comment:3 by , 15 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:4 by , 15 years ago
Note:
See TracTickets
for help on using tickets.
(In [12492]) Fixed #12570. Removed unused fields from GenericForeignKey. Thanks, specialunderwear.