Opened 6 years ago

Closed 5 years ago

Last modified 4 years ago

#12570 closed (fixed)

BaseGenericInlineFormSet has unused members

Reported by: specialunderwear Owned by: nobody
Component: Contrib apps Version: 1.2-alpha
Severity: Keywords: contenttypes unused code BaseGenericInlineFormSet
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

BaseGenericInlineFormSet has 2 members which are never changed or referenced by any code. This is confusing other developers. For example in django-reversion there used to be a bug in which the name of the content type foreign key, was determined by ct_fk_field_name instead of ct_fk_field.name. ct_fk_field_name is one of the unused members.

Code that is never used should be removed to avoid confusion.

Please see attached patched against current trunk.

Attachments (1)

basegenricinlineformset_unused_code_removed.diff (526 bytes) - added by specialunderwear 6 years ago.

Download all attachments as: .zip

Change History (6)

Changed 6 years ago by specialunderwear

comment:1 Changed 5 years ago by russellm

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 5 years ago by russellm

  • Component changed from Uncategorized to Contrib apps

comment:3 Changed 5 years ago by jkocherhans

  • Resolution set to fixed
  • Status changed from new to closed

(In [12492]) Fixed #12570. Removed unused fields from GenericForeignKey. Thanks, specialunderwear.

comment:4 Changed 5 years ago by jkocherhans

(In [12495]) [1.1.X] Fixed #12570. Removed unused fields from GenericForeignKey. Backport of r12492 from trunk.

comment:5 Changed 4 years ago by jacob

  • milestone 1.2 deleted

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top