Opened 6 years ago

Closed 6 years ago

#12492 closed (fixed)

Three new literals in djangojs message file

Reported by: ramiro Owned by: jezdez
Component: Internationalization Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Since r11964 and r12030 the 'FIRST_DAY_OF_WEEK', 'TIME_INPUT_FORMATS' and 'DATE_INPUT_FORMATS' literals are being picked up by makemessages when running it over the djangojs domain.

Reason is we are wrapping them with a gettext call, but what we really want is the runtime behavior (having these taken from the Javascript i18n catalog) without they appearing in the djangojs.po files because 1) if the translator translates them these transalation override what is specified in formats.py (possibly customized by the deployer, 2) we are forcing him/her to maintain the same translations in two places and 3) Conversely, if nobody translates them in djangojs.po then the respective formats specified in the relevant formats.py aren't being applied either.

Change History (2)

comment:1 Changed 6 years ago by jezdez

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to jezdez
  • Patch needs improvement unset
  • Status changed from new to assigned
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 6 years ago by jezdez

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [12081]) Fixed #12492 - Refactored JavaScript format localization by separating it from the translation backend. Thanks, Ramiro Morales.

Note: See TracTickets for help on using tickets.
Back to Top