Opened 7 years ago

Closed 3 years ago

#12491 closed Bug (fixed)

help_text for checkbox badly aligned if not on its own line

Reported by: master Owned by: Ramiro Morales
Component: contrib.admin Version: 1.1
Severity: Normal Keywords: help_text design_ux
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description (last modified by Ramiro Morales)

help_text is badly aligned under its checkbox when not alone on the line.

Due to media/css/forms.css:

If the chekbox is on its own line: .checkbox-row p.help applies, with a padding-left: 0, it's ok.

Otherwise: form .aligned p.help applies, with a padding-left: 38px, which gives an ugly rendering.

Attachments (1)

48.png (13.8 KB) - added by Ramiro Morales 3 years ago.
Checkbox help text layout before the proposed fix.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 7 years ago by Russell Keith-Magee

Keywords: design_ux added
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

comment:2 Changed 5 years ago by Matt McClanahan

Severity: Normal
Type: Bug

comment:3 Changed 5 years ago by Julien Phalip

UI/UX: set

comment:4 Changed 5 years ago by Aymeric Augustin

UI/UX: unset

Change UI/UX from NULL to False.

comment:5 Changed 5 years ago by Aymeric Augustin

Easy pickings: unset

Change Easy pickings from NULL to False.

comment:6 Changed 5 years ago by Aymeric Augustin

UI/UX: set

Revert accidental batch modification.

comment:7 Changed 4 years ago by Niels van Dijk

I have written a patch for this ticket: https://github.com/django/django/pull/771

Styling was already their but the class name was not used in any template. In admin forms, the help text of a checkbox field will start at the beginning of the line. No indentation. See screenshot:

http://i48.tinypic.com/24fms69.png

comment:8 Changed 4 years ago by Claude Paroz

Has patch: set

comment:9 Changed 3 years ago by Ramiro Morales

Owner: changed from nobody to Ramiro Morales
Status: newassigned

comment:10 Changed 3 years ago by Ramiro Morales

Description: modified (diff)

Changed 3 years ago by Ramiro Morales

Attachment: 48.png added

Checkbox help text layout before the proposed fix.

comment:11 Changed 3 years ago by Ramiro Morales

This screen capture shows the alignment of the help text before the fix proposed by nvandijk:

Checkbox help text layout before the proposed fix.

comment:12 Changed 3 years ago by Ramiro Morales <cramm0@…>

Resolution: fixed
Status: assignedclosed

In 7a923128278e9e07cd8e7ca50400ba24617825dd:

Fixed #12491 -- Tweak checkbox widget help text alignment on the admin.

Thanks master' for the report and Niels van Dijk for the fix

Note: See TracTickets for help on using tickets.
Back to Top