Code

Opened 4 years ago

Closed 4 years ago

#12424 closed (wontfix)

Trac fix for the viewing [11952]

Reported by: jemfinch Owned by: nobody
Component: Uncategorized Version: 1.1
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

A friend pointed me at http://www.djangoproject.com/multidb-changeset/ and I recognized the issue as one I fixed for my employer's Trac instance recently. I got permission to share the fix, so I've attached the diff to versioncontrol/web_ui/changeset.py in 0.11.1-2.1 (from Ubuntu Jaunty).

I can't say whether it will work as-is in your case (it really depends on how those 21,000 lines are distributed across files) but you can tweak the numbers as necessary to avoid "huge diff" computational issue with this changeset and others in the future.

Attachments (1)

trac-patch.diff (1022 bytes) - added by jemfinch 4 years ago.

Download all attachments as: .zip

Change History (3)

Changed 4 years ago by jemfinch

comment:1 Changed 4 years ago by jemfinch

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

On looking at the actual diff, it seems that this patch won't help, since this patch is intended to assist with very large single-file diffs, rather than large numbers of smaller diffs. Oh well.

comment:2 Changed 4 years ago by russellm

  • Resolution set to wontfix
  • Status changed from new to closed

Closed on the basis that the reporter says it won't work, and we've got a workaround in place.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.