Opened 15 years ago
Closed 15 years ago
#12402 closed (fixed)
QuerySet.defer does not work properly on Oracle
Reported by: | Jani Tiainen | Owned by: | jbronn |
---|---|---|---|
Component: | Database layer (models, ORM) | Version: | dev |
Severity: | Keywords: | orm oracle defer | |
Cc: | Triage Stage: | Unreviewed | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description (last modified by )
The machinery in OracleQuery.resolve_columns
does not take into account any fields that are deferred. Seeing this error depends on the order of the fields, and how they are handled by OracleQuery.convert_values
-- which is probably why it's missed in the test suite. Here's an example model that demonstrates the problem:
from django.db import models class MyModel(models.Model): num = models.FloatField() name = models.CharField(max_length=128)
Here's how to raise it:
>>> MyModel.objects.create(num=5.0, name='Foobar') <MyModel: MyModel object> >>> qs = MyModel.objects.defer('num') >>> print qs Traceback (most recent call last): File "<ipython console>", line 1, in <module> File "C:\Python25\lib\site-packages\IPython\Prompts.py", line 552, in __call__ manipulated_val = self.display(arg) File "C:\Python25\lib\site-packages\IPython\Prompts.py", line 578, in _display return self.shell.hooks.result_display(arg) File "C:\Python25\lib\site-packages\IPython\hooks.py", line 141, in __call__ ret = cmd(*args, **kw) File "C:\Python25\lib\site-packages\IPython\hooks.py", line 171, in result_display out = pformat(arg) File "C:\Python25\lib\pprint.py", line 111, in pformat self._format(object, sio, 0, 0, {}, 0) File "C:\Python25\lib\pprint.py", line 129, in _format rep = self._repr(object, context, level - 1) File "C:\Python25\lib\pprint.py", line 195, in _repr self._depth, level) File "C:\Python25\lib\pprint.py", line 207, in format return _safe_repr(object, context, maxlevels, level) File "C:\Python25\lib\pprint.py", line 292, in _safe_repr rep = repr(object) File "C:\django\trunk\django\db\models\query.py", line 61, in __repr__ data = list(self[:REPR_OUTPUT_SIZE + 1]) File "C:\django\trunk\django\db\models\query.py", line 76, in __len__ self._result_cache.extend(list(self._iter)) File "C:\django\trunk\django\db\models\query.py", line 261, in iterator for row in self.query.results_iter(): File "C:\django\trunk\django\db\models\sql\query.py", line 292, in results_iter row = self.resolve_columns(row, fields) File "C:\django\trunk\django\db\backends\oracle\query.py", line 54, in resolve_columns values.append(self.convert_values(value, field)) File "C:\django\trunk\django\db\backends\oracle\query.py", line 74, in convert_values value = float(value) ValueError: invalid literal for float(): Foobar
The problem reveals itself here because although we've deferred the FloatField
, it's instance is still passed into convert_values
with the value associated with the CharField
.
Attachments (1)
Change History (5)
comment:1 by , 15 years ago
Keywords: | oracle gis added |
---|---|
Owner: | changed from | to
Summary: | Deferring geometry field causes invalid results or crash → Deferring geometry field does not work on Oracle |
comment:2 by , 15 years ago
Component: | GIS → Database layer (models, ORM) |
---|---|
Description: | modified (diff) |
Keywords: | defer added; gis removed |
Status: | new → assigned |
Summary: | Deferring geometry field does not work on Oracle → QuerySet.defer does not work properly on Oracle |
The problem is not GeoDjango related at all, and applies to the entire Oracle backend.
comment:3 by , 15 years ago
Description: | modified (diff) |
---|
by , 15 years ago
Attachment: | defer_resolve_columns_fix_v1.diff added |
---|
comment:4 by , 15 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
This problem only affects the Oracle spatial backend.