Opened 6 years ago

Closed 6 years ago

Last modified 4 years ago

#12364 closed (fixed)

CTRL-C could be caught by the TestRunner to display any failures found so far

Reported by: rpbarlow Owned by: kmtracey
Component: Testing framework Version: master
Severity: Keywords: CTRL-C interrupt signal
Cc: randallpbarlow@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Similar to #11613, it would be very cool if the Django test runner would intercept CTRL-C. If I had been running the unit tests for ~40 minutes or so, and I forgot to put --verbosity or --failfast, it would be cool if I could type CTRL-C to get the test runner to give me all the failures to date. This might not be straightforward, but it would be a nice to have.

Attachments (1)

ticket_12364.patch (3.1 KB) - added by rpbarlow 6 years ago.
This patch adds the ability to quit on a second keyboard interrupt.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 6 years ago by rpbarlow

  • Cc rpbarlow added
  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to rpbarlow
  • Patch needs improvement unset
  • Status changed from new to assigned
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 6 years ago by rpbarlow

  • Needs documentation set
  • Patch needs improvement set

I attached a ghetto patch. It's ghetto because I made it by hand. It also depends on the patch from #11613 being applied. Documentation still required, and on its way!

Changed 6 years ago by rpbarlow

This patch adds the ability to quit on a second keyboard interrupt.

comment:3 Changed 6 years ago by rpbarlow

  • Has patch set
  • Keywords CTRL-C interrupt signal added
  • Needs documentation unset
  • Owner changed from rpbarlow to kmtracey
  • Patch needs improvement unset
  • Status changed from assigned to new
  • Triage Stage changed from Accepted to Ready for checkin

Hey Karen! This one I think is ready to be checked in. We can now do wicked cool things in the test suite when stuff is broked.

comment:4 Changed 6 years ago by rpbarlow

  • Version changed from 1.1 to SVN

comment:5 Changed 6 years ago by rpbarlow

  • Cc randallpbarlow@… added; rpbarlow removed

comment:6 Changed 6 years ago by kmtracey

  • Resolution set to fixed
  • Status changed from new to closed

(In [12034]) Fixed #12364: Added graceful exit from a test run when Ctrl-C is pressed. Thanks Randy Barlow.

comment:7 Changed 4 years ago by jacob

  • milestone 1.2 deleted

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top