Decorator used, without the decorator syntax

[v21]

under ​http://docs.djangoproject.com/en/dev/ref/models/instances/#django.db.models.permalink , there is the following code:

from django.db.models import permalink

def get_absolute_url(self):
    return ('people_view', [str(self.id)])
get_absolute_url = permalink(get_absolute_url)

which should surely be:

from django.db import models

@models.permalink
def get_absolute_url(self):
    return ('people_view', [str(self.id)])

(I also changed the import statement to be more consistent with the previous code snippet.)

[Luke Plant]

Decorator syntax is not a requirement, and doesn't work with Python < 2.4. Since we are dropping Python 2.3 support for Django 1.2, we can of course now use decorator syntax, but it makes more sense to do this either:

• as and when we come across it in the code and are committing related work.
• or en masse, fixing multiple instances across the code base.

For now, I'm not sure what the best thing to do is. Personally I think it's better to just ignore this in existing code, otherwise it will make backporting bug fixes to the 1.1 branch harder than it needs to be — the 1.1 branch of course must still be compatible with Python 2.3.