JSON Deserialiser throws ValueError on malformed input

[Malcolm Box]

/core/serializers/json.py Deserializer uses simplejson to parse the input string. If this input is malformed, then simplejson throws a ValueError exception.

However, the serializer interface appears (see XML & base.py) that it should raise a base.DeserializationError when deserialization fails, not a ValueError. Users of the deserializer (e.g. django-restapi) then fail to handle the ValueError, resulting in Internal Server (500) errors.

The fix is to catch ValueError in json.py (around line 40) and re-raise as a DeserializationError.

Simple patch attached.

[Malcolm Box]

Fix for problem

[Claude Paroz]

Same patch with tests

[anonymous]

This is causing a test to fail related to fixtures:

FAIL: test_fixture_loading (regressiontests.multiple_database.tests.FixtureTestCase)
Multi-db fixtures are loaded correctly
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/admin/Projects/django/django-git/tests/regressiontests/multiple_database/tests.py", line 1639, in test_fixture_loading
    self.fail('"Dive into Python" should exist on other database')
AssertionError: "Dive into Python" should exist on other database

----------------------------------------------------------------------

[Claude Paroz]

Fixed missing options parameter

[Claude Paroz]

Sorry, there was an error in the previous patch (missing **options). Fixed.

[Claude Paroz]

Updated to current trunk

[Jannis Leidel]

In [17469]:

Fixed #11970 -- Wrapped the exception happening during deserialization in DeserializationError exceptions. Thanks, Claude Paroz.