Opened 15 years ago
Closed 12 years ago
#11939 closed Cleanup/optimization (invalid)
Better conventions between generic views and syndication feed framework
Reported by: | fractal | Owned by: | nobody |
---|---|---|---|
Component: | contrib.syndication | Version: | 1.1 |
Severity: | Normal | Keywords: | suggestion, improvement rss object_detail |
Cc: | Triage Stage: | Accepted | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
There is a small inconsistency between generic view object_detail and item template from the feed framework.
One names the return object: {{ object }} the other {{ obj }}
Having the same name would simplify the interchange of templates among them.
It is not far fetched to have a generic view for post_detail and using that as the template for item post on the feed.
object_detail documentation:
object: The object. This variable's name depends on the template_object_name parameter, which is 'object' by default. If template_object_name is 'foo', this variable's name will be foo.
syndication feed framework documentation:
feeds/latest_description.html for example uses {{ obj }} -- The current object (one of whichever objects you returned in items()).
Cheers
Change History (5)
comment:1 by , 15 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:2 by , 14 years ago
Severity: | → Normal |
---|---|
Type: | → Cleanup/optimization |
comment:3 by , 13 years ago
UI/UX: | unset |
---|
comment:5 by , 12 years ago
Resolution: | → invalid |
---|---|
Status: | new → closed |
This ticket pertains to the function-based generic views which were removed for Django.
See also #19904.
Change UI/UX from NULL to False.