#11801 closed (fixed)
Should be able to get deleted_forms on a formset even if it contains a deleted form that would have been invalid
| Reported by: | dantallis | Owned by: | nobody |
|---|---|---|---|
| Component: | Forms | Version: | 1.1 |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The attached patch fixes what I think are a couple of little bugs:
- you can't get deleted_forms from a formset if it contains a deleted form that would have been invalid
- similar for ordered_forms
The bug is that the code for those functions queries cleaned_data which doesn't exist if the deleted form would have been invalid.
Attachments (1)
Change History (7)
by , 15 years ago
| Attachment: | formset_deleted_forms.diff added |
|---|
comment:1 by , 15 years ago
| milestone: | → 1.2 |
|---|
comment:2 by , 15 years ago
| Triage Stage: | Unreviewed → Design decision needed |
|---|
comment:3 by , 15 years ago
| Triage Stage: | Design decision needed → Ready for checkin |
|---|
comment:4 by , 15 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:5 by , 15 years ago
Note:
See TracTickets
for help on using tickets.
(In [12771]) Fixed #11801 -- Corrected form validation to ensure you can still get deleted_forms and ordered_forms when a form that is being deleted doesn't validate. Thanks to dantallis for the report and patch.