Opened 7 years ago

Closed 7 years ago

Last modified 5 years ago

#11801 closed (fixed)

Should be able to get deleted_forms on a formset even if it contains a deleted form that would have been invalid

Reported by: dantallis Owned by: nobody
Component: Forms Version: 1.1
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The attached patch fixes what I think are a couple of little bugs:

  • you can't get deleted_forms from a formset if it contains a deleted form that would have been invalid
  • similar for ordered_forms

The bug is that the code for those functions queries cleaned_data which doesn't exist if the deleted form would have been invalid.

Attachments (1)

formset_deleted_forms.diff (4.2 KB) - added by dantallis 7 years ago.

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by dantallis

Attachment: formset_deleted_forms.diff added

comment:1 Changed 7 years ago by anonymous

milestone: 1.2

comment:2 Changed 7 years ago by Cliff Dyer

Triage Stage: UnreviewedDesign decision needed

comment:3 Changed 7 years ago by Jacob

Triage Stage: Design decision neededReady for checkin

comment:4 Changed 7 years ago by Russell Keith-Magee

Resolution: fixed
Status: newclosed

(In [12771]) Fixed #11801 -- Corrected form validation to ensure you can still get deleted_forms and ordered_forms when a form that is being deleted doesn't validate. Thanks to dantallis for the report and patch.

comment:5 Changed 7 years ago by Russell Keith-Magee

(In [12772]) [1.1.X] Fixed #11801 -- Corrected form validation to ensure you can still get deleted_forms and ordered_forms when a form that is being deleted doesn't validate. Thanks to dantallis for the report and patch.

Backport of r12771 from trunk.

comment:6 Changed 5 years ago by Jacob

milestone: 1.2

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top