Opened 7 years ago

Closed 5 years ago

#11684 closed Bug (duplicate)

dismissAddAnotherPopup fails with XHTML

Reported by: rlaager@… Owned by: nobody
Component: contrib.admin Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX:

Description

dismissAddAnotherPopup looks at an element's .nodeName case-sensitively. This fails with XHTML. The attached patch fixes this.

Attachments (1)

11684-dismissAddAnotherPopup-xhtml.diff (902 bytes) - added by rlaager@… 7 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 7 years ago by rlaager@…

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

See also #11683

Changed 7 years ago by rlaager@…

comment:2 Changed 7 years ago by Russell Keith-Magee

milestone: 1.2
Triage Stage: UnreviewedAccepted

comment:3 Changed 7 years ago by James Bennett

milestone: 1.2

This is part of the larger issue of dealing with varying output formats, and so is probably best dealt with in a general fashion by a future release, rather than piecemeal in 1.2.

comment:4 Changed 5 years ago by Julien Phalip

Severity: Normal
Type: Bug

comment:5 Changed 5 years ago by Julien Phalip

Easy pickings: unset
Resolution: duplicate
Status: newclosed

This is actually a dupe of #5704.

Note: See TracTickets for help on using tickets.
Back to Top