Opened 7 years ago

Closed 4 years ago

#11626 closed New feature (invalid)

Add Malaysian (my) localflavour

Reported by: Zaim Bakar Owned by: nobody
Component: contrib.localflavor Version:
Severity: Normal Keywords: localflavor, malaysia, my, localflavorsplit
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

Patch to add Malaysian localflavor. Contains form and model fields for Malaysian Identification Number, postcode, phone number and states.

Only tests for form fields are included (help: not sure where to put model field tests for localflavors).

Attachments (1)

my_localflavor.diff (21.3 KB) - added by Zaim Bakar 7 years ago.
Malaysia localflavor patch

Download all attachments as: .zip

Change History (8)

Changed 7 years ago by Zaim Bakar

Attachment: my_localflavor.diff added

Malaysia localflavor patch

comment:1 Changed 7 years ago by Zaim Bakar

Needs tests: set

Need tests for model fields.

comment:2 Changed 7 years ago by Alex Gaynor

Triage Stage: UnreviewedAccepted

comment:3 in reply to:  description Changed 7 years ago by Jannis Leidel

milestone: 1.2

Replying to zaim:

Only tests for form fields are included (help: not sure where to put model field tests for localflavors).

You can put model field tests in source:django/trunk/tests/regressiontests/localflavor where the model fields of the US localflavor are being tested already.

comment:4 Changed 7 years ago by Russell Keith-Magee

milestone: 1.2
Version: SVN

comment:5 Changed 6 years ago by Julien Phalip

Severity: Normal
Type: New feature

comment:6 Changed 5 years ago by Jannis Leidel

Easy pickings: unset
Patch needs improvement: set
UI/UX: unset

This needs to be update to unittests.

comment:7 Changed 4 years ago by Aymeric Augustin

Keywords: localflavorsplit added
Resolution: invalid
Status: newclosed

django.contrib.localflavor is now deprecated (see https://docs.djangoproject.com/en/dev/ref/contrib/localflavor/).

If you'd like, I encourage you to create a django-localflavor- (where is your country code), following the template of all the other django-localflavor- packages. See http://github.com/django for the list.

Once that's done, we can link to it from the documentation.

Thanks for your understanding!

Note: See TracTickets for help on using tickets.
Back to Top