Code

Opened 5 years ago

Closed 18 months ago

#11626 closed New feature (invalid)

Add Malaysian (my) localflavour

Reported by: zaim Owned by: nobody
Component: contrib.localflavor Version:
Severity: Normal Keywords: localflavor, malaysia, my, localflavorsplit
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

Patch to add Malaysian localflavor. Contains form and model fields for Malaysian Identification Number, postcode, phone number and states.

Only tests for form fields are included (help: not sure where to put model field tests for localflavors).

Attachments (1)

my_localflavor.diff (21.3 KB) - added by zaim 5 years ago.
Malaysia localflavor patch

Download all attachments as: .zip

Change History (8)

Changed 5 years ago by zaim

Malaysia localflavor patch

comment:1 Changed 5 years ago by zaim

  • Needs documentation unset
  • Needs tests set
  • Patch needs improvement unset

Need tests for model fields.

comment:2 Changed 5 years ago by Alex

  • Triage Stage changed from Unreviewed to Accepted

comment:3 in reply to: ↑ description Changed 4 years ago by jezdez

  • milestone set to 1.2

Replying to zaim:

Only tests for form fields are included (help: not sure where to put model field tests for localflavors).

You can put model field tests in source:django/trunk/tests/regressiontests/localflavor where the model fields of the US localflavor are being tested already.

comment:4 Changed 4 years ago by russellm

  • milestone 1.2 deleted
  • Version SVN deleted

comment:5 Changed 3 years ago by julien

  • Severity set to Normal
  • Type set to New feature

comment:6 Changed 3 years ago by jezdez

  • Easy pickings unset
  • Patch needs improvement set
  • UI/UX unset

This needs to be update to unittests.

comment:7 Changed 18 months ago by aaugustin

  • Keywords localflavor, malaysia, my, localflavorsplit added; localflavor malaysia my removed
  • Resolution set to invalid
  • Status changed from new to closed

django.contrib.localflavor is now deprecated (see https://docs.djangoproject.com/en/dev/ref/contrib/localflavor/).

If you'd like, I encourage you to create a django-localflavor- (where is your country code), following the template of all the other django-localflavor- packages. See http://github.com/django for the list.

Once that's done, we can link to it from the documentation.

Thanks for your understanding!

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.