Opened 14 years ago

Closed 14 years ago

Last modified 12 years ago

#11625 closed (fixed)

Comment moderation through admin actions

Reported by: Waylan Limberg Owned by: Waylan Limberg
Component: contrib.comments Version: dev
Severity: Keywords: comments admin actions
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

While the (currently undocumented) moderation views of the contrib.comments app are nice, it would be even nicer if the same features were available as admin actions. At least the two actions: Remove selects comments and Approve selected comments should be available. As apposed to the 'delete' action (which actually deletes comments form the db), the 'remove' action would set 'comment.is_removed = True' just as the remove view currently does.

Attachments (5)

comment_mod_actions.diff​ (4.3 KB) - added by Waylan Limberg 14 years ago.
initial patch with tests
comment_mod_actions.2.diff​ (7.1 KB) - added by Waylan Limberg 14 years ago.
initial patch with tests
11625.diff​ (7.4 KB) - added by Waylan Limberg 14 years ago.
Added permission checks to action methods.
11625.2.diff​ (7.6 KB) - added by Waylan Limberg 14 years ago.
Updated/fixed a few issues with the tests.
11625.3.diff​ (16.2 KB) - added by Thejaswi Puthraya 14 years ago.
git-patch against the latest checkout

Download all attachments as: .zip

Change History (12)

Changed 14 years ago by Waylan Limberg

Attachment: comment_mod_actions.diff​ added

initial patch with tests

comment:1 Changed 14 years ago by Alex Gaynor

There seems to be a file missing from this, don't forget to SVN add (or whatever VCS) the new tests file.

Changed 14 years ago by Waylan Limberg

Attachment: comment_mod_actions.2.diff​ added

initial patch with tests

comment:2 Changed 14 years ago by Waylan Limberg

Thanks Alex. I noticed the missing filed right after I submitted. Anyway, I've uploaded an updated patch.

I should note that the tests don't actually pass because the TestClient returns a NotFound response. Not sure if I have the urls wrong, or if there is some trick I'm missing to turn on the admin app with the existing comment tests.

comment:3 Changed 14 years ago by Alex Gaynor

Triage Stage: Unreviewed → Accepted

comment:4 Changed 14 years ago by anonymous

milestone: → 1.2
Owner: changed from nobody to anonymous
Status: new → assigned
Version: 1.1-beta-1 → SVN

comment:5 Changed 14 years ago by Waylan Limberg

Owner: changed from anonymous to Waylan Limberg
Status: assigned → new

Whoops that was me.

Changed 14 years ago by Waylan Limberg

Attachment: 11625.diff​ added

Added permission checks to action methods.

Changed 14 years ago by Waylan Limberg

Attachment: 11625.2.diff​ added

Updated/fixed a few issues with the tests.

Changed 14 years ago by Thejaswi Puthraya

Attachment: 11625.3.diff​ added

git-patch against the latest checkout

comment:6 Changed 14 years ago by Jacob

Resolution: → fixed
Status: new → closed

(In [11639]) Fixed #11625: added comment moderation via admin actions.

This is BACKWARDS INCOMPATIBLE if you were using the completely undocumented moderation view from 1.1. That view's been removed in favor of the admin actions.

Thanks, Thejaswi Puthraya.

comment:7 Changed 12 years ago by Jacob

milestone: 1.2

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top