Django copies .pyo files for a new project/app

[Steve Milner]

Ignacio Vazquez-Abrams noted that if pyo files are present Django copys them into projects/apps. Currently, core.management.base stops pyc's from being copied but does not stop pyo's. Ignacio proposed adding the same block on pyo's (see patch attached).

​RH Bugzilla Bug

[Steve Milner]

Does not copy over pyo's

[Steve Milner]

What if we switched this on it's ear and instead and did:

    if !f.endswith('.py'):

that way other implementations (such as jython) which may create files with different bytecode suffixes don't get items copied as well. Just a thought.

[Steve Milner]

Oops ...

    if not f.endswith('.py'):

[crankycoder@…]

This bug actually causes breakage in Django 1.0.x on Jython. The startproject and startapp commands incorrectly use the '.pyc' filter and end up *rewriting* the Jython generated class files.

Can we get this applied to the 1.0.x branch quickly?

[Frank Wierzbicki]

Turn Steve Milner's second idea into a patch, as it helps Jython too

[Frank Wierzbicki]

A third possibility (If there are files other than .py that need processing) is to just add an "or f.endswith("$py.class") to the list for Jython. I'll put that patch together if it will speed things along...

[Brandon Taylor]

I'm seeing the same thing for 1.0.3 on Jython 2.5.0. After creating a new project, I'm unable to runserver until I delete the initial .class files

[Luke Plant]

Fixed in r11483.

(is the post-commit hook that should write this message broken?)

Because 1.1 is released, 1.0.X will now only receive security bug fixes, so this won't be backported (unless policy changes).

[Leo Soto M.]

Replying to lukeplant:

Fixed in r11483.

(is the post-commit hook that should write this message broken?)

Because 1.1 is released, 1.0.X will now only receive security bug fixes, so this won't be backported (unless policy changes).

That's a shame. I understand that Django is run by volunteers and you can't afford to make all the releases we want. The problem here is that Django 1.1 hasn't been tested with Jython as extensively as 1.0, so we Jython users are a bit in the dark now :(

[Luke Plant]

Replying to leosoto:

That's a shame. I understand that Django is run by volunteers and you can't afford to make all the releases we want. The problem here is that Django 1.1 hasn't been tested with Jython as extensively as 1.0, so we Jython users are a bit in the dark now :(

Changing the policy regarding backporting would make more work for our release manager, so I'm loathe to suggest that.

Perhaps someone from the community could set up a git/hg mirror that is "1.0.X plus Jython fixes"? With mercurial at least, it is pretty easy to do - just clone ​http://bitbucket.org/mirror/django-10x/, create a 'jython_fixes' branch (or something like that) which has hand-selected backports (like changeset r11483) added to it. Provided the fixes for Jython are small, merging from django-1.0.X will be very easy.

[Steve Milner]

For the moment we are applying the original patch to all Fedora built Django packages using the rpm patch directive. On next update we will test and apply the updated patch by Frank.